From: Kevin Wolf <kwolf@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/2] block: clean up bdrv_open2 structure a bit
Date: Tue, 12 Jan 2010 18:14:58 +0100 [thread overview]
Message-ID: <4B4CAE12.9020704@redhat.com> (raw)
In-Reply-To: <20100112170905.GA31233@lst.de>
Am 12.01.2010 18:09, schrieb Christoph Hellwig:
> On Tue, Jan 12, 2010 at 05:04:00PM +0100, Kevin Wolf wrote:
>> To keep the behaviour as previously you'd need to set at least bs->drv
>> in the unlink_and_fail case, too. I have no clue why it's important to
>> set it to NULL when bs isn't going to be used anyway (probably it is,
>> but I don't know where), but Fabrice committed this in 6b21b973 as a
>> fix. Unfortunately, the commit message looks like most of Fabrice's
>> commit messages, so it's of no use for me...
>
> The unlink_and_fail label can only be reached from places where we
> haven't set bs->drv yet, so it should be fine.
Sorry, I confused drv and bs->drv. Looks alright then.
Acked-by: Kevin Wolf <kwolf@redhat.com>
prev parent reply other threads:[~2010-01-12 17:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-11 17:51 [Qemu-devel] [PATCH 1/2] block: clean up bdrv_open2 structure a bit Christoph Hellwig
2010-01-12 16:04 ` Kevin Wolf
2010-01-12 17:09 ` Christoph Hellwig
2010-01-12 17:14 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B4CAE12.9020704@redhat.com \
--to=kwolf@redhat.com \
--cc=hch@lst.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.