From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1NUlr9-00065Y-PR for mharc-grub-devel@gnu.org; Tue, 12 Jan 2010 13:52:43 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NUlr7-00063N-S0 for grub-devel@gnu.org; Tue, 12 Jan 2010 13:52:41 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NUlr2-0005vH-65 for grub-devel@gnu.org; Tue, 12 Jan 2010 13:52:40 -0500 Received: from [199.232.76.173] (port=48119 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NUlr2-0005v1-10 for grub-devel@gnu.org; Tue, 12 Jan 2010 13:52:36 -0500 Received: from mail-fx0-f228.google.com ([209.85.220.228]:62892) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NUlr1-0006av-Gc for grub-devel@gnu.org; Tue, 12 Jan 2010 13:52:35 -0500 Received: by fxm28 with SMTP id 28so14200600fxm.26 for ; Tue, 12 Jan 2010 10:52:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:content-type :content-transfer-encoding; bh=Eu5K//JPPNg+vArmY3+qtgmz8FolyWNJ85nsn1L6edA=; b=GwRboFfGUhC2KfkH3Sx45tjdxrEE5dC9JWQlKQ/G7ZbwganhexH3kmyfn+Qx+/6I2Y tL177VsQ7fTAMJUre5Er0yrzI+BvEn2DH3BZZ4DZT1Xobde6J1dD/decUv7OM/e47Kx5 Qzu1mIGtdhFicroxcSfi/riHzP7KwFGIVsrrQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject :content-type:content-transfer-encoding; b=GfVSs7p1HszMt5pRuBC/wvYer1Y/TsD0TfpSP9LcMQgoUsbI2/1lbwPK1Fp2QPyUFY PvA2VhViPlffpAHKMXeTK+s3+SJNdu6IHY/Ad5KSrRouSNlJgelRCHtjtetRGqRMmKSs fIetZrfQm+5r+NrEzPVxfi/imWjSy3S0i8lYY= Received: by 10.223.14.13 with SMTP id e13mr11589696faa.85.1263322353516; Tue, 12 Jan 2010 10:52:33 -0800 (PST) Received: from ?147.210.129.1? (laptop-147-210-129-1.labri.fr [147.210.129.1]) by mx.google.com with ESMTPS id 14sm10384798fxm.15.2010.01.12.10.52.32 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 12 Jan 2010 10:52:33 -0800 (PST) Message-ID: <4B4CC4EF.5000104@gmail.com> Date: Tue, 12 Jan 2010 19:52:31 +0100 From: =?ISO-8859-1?Q?Gr=E9goire_Sutre?= User-Agent: Thunderbird 2.0.0.23 (X11/20091027) MIME-Version: 1.0 To: The development of GRUB 2 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Build error: "ENABLE_NLS" is not defined X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Jan 2010 18:52:42 -0000 Hi, When NLS is disabled or not supported, the macro ENABLE_NLS is not defined, and this breaks compilation of GRUB modules as they are compiled with -Werror -Wundef by default. This is with bazaar trunk. $ ./autogen.sh && ./configure && gmake [...] gcc -Ikern -I./kern -nostdinc -isystem /usr/include -I./include -I. -I./include -Wall -W -Os -DGRUB_MACHINE_PCBIOS=1 -Wall -W -Wshadow -Wpointer-arith -Wmissing-prototypes -Wundef -Wstrict-prototypes -g -falign-jumps=1 -falign-loops=1 -falign-functions=1 -mno-mmx -mno-sse -mno-sse2 -mno-3dnow -m32 -fno-stack-protector -mno-stack-arg-probe -Werror -fno-builtin -mrtd -mregparm=3 -m32 -MD -c -o kernel_img-kern_err.o kern/err.c In file included from kern/err.c:23: ./include/grub/i18n.h:29:5: error: "ENABLE_NLS" is not defined gmake: *** [kernel_img-kern_err.o] Error 1 A possible fix consists in replacing the #if ENABLE_NLS by #if defined(ENABLE_NLS). There are not many instances, so they can be changed manually, but the following command did the trick for me (assuming sed is GNU sed): find . -name '*.[ch]' -exec sed -i -e 's, ENABLE_NLS, defined(ENABLE_NLS),g' '{}' ';' Best, Grégoire