From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1NUmSs-0002Xt-Ev for mharc-grub-devel@gnu.org; Tue, 12 Jan 2010 14:31:42 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NUmSr-0002Xn-EW for grub-devel@gnu.org; Tue, 12 Jan 2010 14:31:41 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NUmSm-0002XG-DN for grub-devel@gnu.org; Tue, 12 Jan 2010 14:31:40 -0500 Received: from [199.232.76.173] (port=41341 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NUmSm-0002XD-88 for grub-devel@gnu.org; Tue, 12 Jan 2010 14:31:36 -0500 Received: from mail-fx0-f228.google.com ([209.85.220.228]:59350) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NUmSl-000273-Ra for grub-devel@gnu.org; Tue, 12 Jan 2010 14:31:36 -0500 Received: by fxm28 with SMTP id 28so14242704fxm.26 for ; Tue, 12 Jan 2010 11:31:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=nOLUrREkY4lFBuQAxqSYOSOnbpVfwzEdPpoor8SEFXM=; b=BbgDt2WxGe3CfRNRdBJ0t4BLhzQ0IIZFNzFTm4T93eklrPwTdCYz5veK5dZT1ljY+B Yru92DnVU6VRngF2eNE9YcmNS5kEf0Ns1YzPvKgk0txYtsMeRZ6Nb14eZqVyDBrBUGWO NfTt4kK1DkM7ETM1yOZ25G7vNqVsFpRjmpgXI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; b=HbQdbKo1mI3wVtMaSUG+UCJsnYonEp04oyMhpGNE3dx3c+Te8PUmcjQUrFQHOnn0j1 Cnaqq7zeVp1dzPngcFQX3Lo83ZQB52uJhnQN+rGxYgBMVlMNGN5V+SiUYih+FQG4GLVb wMmKz0grrdt9/Trq0GcDLj+BEjTeQEy6z0mVs= Received: by 10.223.6.9 with SMTP id 9mr379412fax.84.1263324693949; Tue, 12 Jan 2010 11:31:33 -0800 (PST) Received: from ?147.210.129.1? (laptop-147-210-129-1.labri.fr [147.210.129.1]) by mx.google.com with ESMTPS id 13sm10398278fxm.1.2010.01.12.11.31.33 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 12 Jan 2010 11:31:33 -0800 (PST) Message-ID: <4B4CCE14.7060706@gmail.com> Date: Tue, 12 Jan 2010 20:31:32 +0100 From: =?UTF-8?B?R3LDqWdvaXJlIFN1dHJl?= User-Agent: Thunderbird 2.0.0.23 (X11/20091027) MIME-Version: 1.0 To: The development of GNU GRUB References: <4B4CC4EF.5000104@gmail.com> <2e59e6971001121109t5314e819t30ee70bb509254e2@mail.gmail.com> In-Reply-To: <2e59e6971001121109t5314e819t30ee70bb509254e2@mail.gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: Build error: "ENABLE_NLS" is not defined X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Jan 2010 19:31:41 -0000 richardvoigt@gmail.com wrote: > This fix breaks when ENABLE_NLS is defined as 0. AFAICS, in the implementation of AM_GNU_GETTEXT, ENABLE_NLS is either not defined or set to 1. But I agree that my proposed fix is too dependent on the implementation of AM_GNU_GETTEXT, which may change. Another option would be to replace #if ENABLE_NLS by #if defined(ENABLE_NLS) && ENABLE_NLS. > This gcc bug is blocking a better solution: > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38105 I didn't know that this was a gcc bug. It felt like a normal behavior to me to get an error with both -Wundef and -Werror in that case. From the gcc man page: -Werror Make all warnings into errors. -Wundef Warn if an undefined identifier is evaluated in an #if directive. Grégoire