Re: [PATCH 2.6.33-rc3] sata_promise: don't classify overruns as HSM errors

[Jeff Garzik <jgarzik@pobox.com>]

On 01/09/2010 05:32 PM, Mikael Pettersson wrote:
> When sata_promise encounters an overrun or underrun error it
> translates that to a libata AC_ERR_HSM, causing a hard reset.
> Since over/under-runs were thought to be rare and transient,
> this action seemed reasonable.
>
> Unfortunately it turns out that the controller throws overrun
> errors when e.g. hal polls a CD or DVD writer containing blank
> media, causing long sequences of hard resets and retries before
> EH finally gives up.
>
> This patch updates sata_promise to classify over/under-runs as
> AC_ERR_OTHER instead. This allows libata EH and upper layers to
> retry or fail the operation as they see fit without the disruption
> caused by repeated hard resets.
>
> This fixes a problem using a DVD-RAM drive with sata_promise,
> reported by Thomas Schorpp. I also tested it on a DVD-RW drive.
>
> Signed-off-by: Mikael Pettersson<mikpe@it.uu.se>
> Tested-by: thomas schorpp<thomas.schorpp@googlemail.com>
> ---
>   drivers/ata/sata_promise.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

applied