From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NUpP7-0005qy-C3
	for qemu-devel@nongnu.org; Tue, 12 Jan 2010 17:40:01 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NUpP1-0005nQ-Nu
	for qemu-devel@nongnu.org; Tue, 12 Jan 2010 17:40:00 -0500
Received: from [199.232.76.173] (port=33107 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NUpP1-0005nI-H1
	for qemu-devel@nongnu.org; Tue, 12 Jan 2010 17:39:55 -0500
Received: from qw-out-1920.google.com ([74.125.92.149]:31911)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1NUpP1-0005lr-5f
	for qemu-devel@nongnu.org; Tue, 12 Jan 2010 17:39:55 -0500
Received: by qw-out-1920.google.com with SMTP id 14so150018qwa.4
	for <qemu-devel@nongnu.org>; Tue, 12 Jan 2010 14:39:54 -0800 (PST)
Message-ID: <4B4CFA38.3070008@codemonkey.ws>
Date: Tue, 12 Jan 2010 16:39:52 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <cover.1263230079.git.mst@redhat.com>
	<20100111172217.GJ11936@redhat.com>
In-Reply-To: <20100111172217.GJ11936@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH-RFC 09/13] tap: add vhost/vhostfd options
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org

On 01/11/2010 11:22 AM, Michael S. Tsirkin wrote:
> Looks like order got mixed up: vhost_net header
> is added by a follow-up patch. Will be fixed
> in the next revision.
>
> Signed-off-by: Michael S. Tsirkin<mst@redhat.com>
> ---
>   net.c           |    8 ++++++++
>   net/tap.c       |   29 +++++++++++++++++++++++++++++
>   qemu-options.hx |    4 +++-
>   3 files changed, 40 insertions(+), 1 deletions(-)
>
> diff --git a/net.c b/net.c
> index 6ef93e6..b942d03 100644
> --- a/net.c
> +++ b/net.c
> @@ -976,6 +976,14 @@ static struct {
>                   .name = "vnet_hdr",
>                   .type = QEMU_OPT_BOOL,
>                   .help = "enable the IFF_VNET_HDR flag on the tap interface"
> +            }, {
> +                .name = "vhost",
> +                .type = QEMU_OPT_BOOL,
> +                .help = "enable vhost-net network accelerator",
> +            }, {
> +                .name = "vhostfd",
> +                .type = QEMU_OPT_STRING,
> +                .help = "file descriptor of an already opened vhost net device",
>               },
>    

Semantically, I think making vhost it's own backend makes more sense 
from a user perspective.

I don't think it's a significant code change.

Regards,

Anthony Liguori