From: Zhu Yanhai <yanhai.zhu@linux.intel.com>
To: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] Don't pass down NULL path to dbus if no modem.
Date: Wed, 13 Jan 2010 15:46:25 +0800 [thread overview]
Message-ID: <4B4D7A51.5000702@linux.intel.com> (raw)
In-Reply-To: <20100113073539.GA18361@jh-x301>
On 01/13/2010 03:35 PM, Johan Hedberg wrote:
> On Wed, Jan 13, 2010, Zhu Yanhai wrote:
>>> 2. Leaking modem_obj_path if it was already set
>> I think it will be freed in telephony_exit().
>
> The point was that if you fetch the modems list more than once or if
> there's more than one modem the previous value of modem_obj_path will be
> overwritten with a new one without freeing the original string first.
>
> Johan
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
I see...it seems that we don't have multiple modems plan yet...ok let's
just use the first modem we saw in the system. I will patch this part and
send a separate patch later today.
Thanks,
Zhu Yanhai
next prev parent reply other threads:[~2010-01-13 7:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-12 6:15 [PATCH] Don't pass down NULL path to dbus if no modem Zhu Yanhai
2010-01-12 6:25 ` Zhu Yanhai
2010-01-13 6:28 ` Johan Hedberg
2010-01-13 6:52 ` Zhu Yanhai
2010-01-13 7:35 ` Johan Hedberg
2010-01-13 7:46 ` Zhu Yanhai [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-01-11 7:36 Zhu Yanhai
2010-01-11 13:53 ` Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B4D7A51.5000702@linux.intel.com \
--to=yanhai.zhu@linux.intel.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.