From: William Allen Simpson <william.allen.simpson@gmail.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Linux Kernel Developers <linux-kernel@vger.kernel.org>,
Linux Kernel Network Developers <netdev@vger.kernel.org>,
Michael Chan <mchan@broadcom.com>
Subject: Re: [PATCH 1/2] net: tcp_header_len_th and tcp_option_len_th
Date: Wed, 13 Jan 2010 06:03:35 -0500 [thread overview]
Message-ID: <4B4DA887.5070309@gmail.com> (raw)
In-Reply-To: <4B4D99B0.8090102@gmail.com>
Eric Dumazet wrote:
2) You also should know that sizeof() is *strongly* typed (size_t),
> not an "untyped constant".
>
My apologies, it's fairly early in the morning here -- I meant
"unsigned" rather than "untyped".
> The (int) cast it not only _not_ needed, its also confusing.
>
I'm sorry for your confusion. I believe it adds clarity.
Moreover, it's fairly egregious that the old tcp_hdrlen()
contributor didn't take signed versus unsigned into account.
Perhaps we could move along to more substantive issues....
Have you had an opportunity to test PATCH 2/2 in this series?
next prev parent reply other threads:[~2010-01-13 11:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-06 21:18 [PATCH 0/2] net: replace buggy tcp_optlen, and cleanup William Allen Simpson
2010-01-06 21:28 ` [PATCH 1/2] net: tcp_header_len_th and tcp_option_len_th William Allen Simpson
2010-01-12 10:40 ` Eric Dumazet
2010-01-12 17:42 ` William Allen Simpson
2010-01-12 17:53 ` Eric Dumazet
2010-01-12 20:27 ` Jarek Poplawski
2010-01-13 8:53 ` William Allen Simpson
2010-01-13 10:00 ` Eric Dumazet
2010-01-13 11:03 ` William Allen Simpson [this message]
2010-01-06 21:37 ` [PATCH 2/2] net: remove old tcp_optlen function William Allen Simpson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B4DA887.5070309@gmail.com \
--to=william.allen.simpson@gmail.com \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.