From: Michal Marek <mmarek@suse.cz>
To: Nir Tzachar <nir.tzachar@gmail.com>
Cc: linux-kbuild@vger.kernel.org, Jan Engelhardt <jengelh@medozas.de>
Subject: Re: [PATCH] ncofig v7 minor fix
Date: Wed, 13 Jan 2010 14:43:40 +0100 [thread overview]
Message-ID: <4B4DCE0C.9040101@suse.cz> (raw)
In-Reply-To: <1263360755-32281-1-git-send-email-nir.tzachar@gmail.com>
On 13.1.2010 06:32, Nir Tzachar wrote:
> This patch fixes two problems reported by Jan Engelhardt:
> 1) Border is now properly placed, to always be visible
> 2) Long menu items are properly displayed
>
> Signed-off-by: Nir Tzachar <nir.tzachar@gmail.com>
Thanks, applied, but please CC linux-kbuild@vger.kernel.org next time.
Michal
>
> ---
> scripts/kconfig/nconf.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/scripts/kconfig/nconf.c b/scripts/kconfig/nconf.c
> index 8c56150..cab6bb0 100644
> --- a/scripts/kconfig/nconf.c
> +++ b/scripts/kconfig/nconf.c
> @@ -984,7 +984,7 @@ static void build_conf(struct menu *menu)
> break;
> default:
> tmp = 2 + strlen(sym_get_string_value(sym));
> - item_make(menu, 's', "(%s)",
> + item_make(menu, 's', " (%s)",
> sym_get_string_value(sym));
> tmp = indent - tmp + 4;
> if (tmp < 0)
> @@ -1072,8 +1072,8 @@ static void show_menu(const char *prompt, const char *instructions,
>
> /* position the menu at the middle of the screen */
> scale_menu(curses_menu, &maxy, &maxx);
> - maxx = min(maxx, mwin_max_cols);
> - maxy = mwin_max_lines-1;
> + maxx = min(maxx, mwin_max_cols-2);
> + maxy = mwin_max_lines-2;
> menu_window = derwin(main_window,
> maxy,
> maxx,
parent reply other threads:[~2010-01-13 13:43 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1263360755-32281-1-git-send-email-nir.tzachar@gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B4DCE0C.9040101@suse.cz \
--to=mmarek@suse.cz \
--cc=jengelh@medozas.de \
--cc=linux-kbuild@vger.kernel.org \
--cc=nir.tzachar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.