From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jeff Garzik <jeff@garzik.org>
Subject: Re: [PATCH] cld: use XDR for all messages
Date: Wed, 13 Jan 2010 17:16:24 -0500
Message-ID: <4B4E4638.5020305@garzik.org>
References: <1263135651-5407-1-git-send-email-cmccabe@alumni.cmu.edu>	<4B4E3531.3010004@garzik.org> <20100113143809.1c3d4600@redhat.com>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Return-path: <hail-devel-owner@vger.kernel.org>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=gamma;
        h=domainkey-signature:received:received:sender:message-id:date:from
         :user-agent:mime-version:to:cc:subject:references:in-reply-to
         :content-type:content-transfer-encoding;
        bh=xIqYbipzRzJ12Aq8oqquYAyxULhNyxPf0oXBNtbzvO0=;
        b=lHCfx+ovTq3ZPIIjNiPI2LSZHhKAGkMRbWQU/UuXu/VwEGDK9tn+y1VkiqYiGdExoC
         mNg6uGfiopE0FFBOCdEefqksZ36BYICf+uCZgOHJmeN3OkDYLsclvs1A0lzzJJDvaQu3
         FRMpGyS1F/mqNF9/NsSL+Bp8f1eqNW7I3KNjw=
In-Reply-To: <20100113143809.1c3d4600@redhat.com>
Sender: hail-devel-owner@vger.kernel.org
List-ID: <hail-devel.vger.kernel.org>
Content-Type: text/plain; charset="us-ascii"; format="flowed"
To: Pete Zaitcev <zaitcev@redhat.com>, Colin McCabe <cmccabe@alumni.cmu.edu>
Cc: Project Hail List <hail-devel@vger.kernel.org>

On 01/13/2010 04:38 PM, Pete Zaitcev wrote:
> On Wed, 13 Jan 2010 16:03:45 -0500
> Jeff Garzik<jeff@garzik.org>  wrote:
>
>> Well, this definitely does not build as-is.  lib/Makefile.am needs
>>
>> 	BUILT_SOURCES           = cld_msg_rpc.h
>>
>> otherwise nothing builds at all, because cld_msg_rpc.h does not exist.
>> test/Makefile.am and tools/Makefile.am both need
>>
>> 	-I$(top_srcdir)/lib
>>
>> added to their INCLUDES. []
>
> Kernel places generated files into the top include directory,
> e.g. autoconf.h and asm-offsets.h for asm/. It's probably easier
> than piling up include paths. I dunno.

Anything other than $(top_srcdir)/include requires an addition to 
INCLUDES.  (remember, build-dir != src-dir always, especially with 'make 
distcheck')

Speaking of 'make distcheck', that is broken in the XDR patch, too. 
include/Makefile.am needs cld_fmt.h added to include_HEADERS.

	Jeff