From: Anthony Liguori <anthony@codemonkey.ws>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] osdep.c: Fix accept4 fallback
Date: Wed, 13 Jan 2010 17:28:19 -0600 [thread overview]
Message-ID: <4B4E5713.6020607@codemonkey.ws> (raw)
In-Reply-To: <1263396056-7816-1-git-send-email-kwolf@redhat.com>
On 01/13/2010 09:20 AM, Kevin Wolf wrote:
> Commit 3a03bfa5 added a fallback in case the Linux kernel running qemu is older
> than the kernel of the build system. Unfortunately, v1 was committed instead of
> v2, so the code has a bug that was revealed in the review (checking for the
> wrong error code).
>
> Signed-off-by: Kevin Wolf<kwolf@redhat.com>
>
Applied. Thanks.
Regards,
Anthony Liguori
> ---
> osdep.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/osdep.c b/osdep.c
> index e4836e7..1310684 100644
> --- a/osdep.c
> +++ b/osdep.c
> @@ -297,7 +297,7 @@ int qemu_accept(int s, struct sockaddr *addr, socklen_t *addrlen)
>
> #ifdef CONFIG_ACCEPT4
> ret = accept4(s, addr, addrlen, SOCK_CLOEXEC);
> - if (ret != -1 || errno != EINVAL) {
> + if (ret != -1 || errno != ENOSYS) {
> return ret;
> }
> #endif
>
prev parent reply other threads:[~2010-01-13 23:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-13 15:20 [Qemu-devel] [PATCH] osdep.c: Fix accept4 fallback Kevin Wolf
2010-01-13 23:28 ` Anthony Liguori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B4E5713.6020607@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.