From: Cole Robinson <crobinso@redhat.com>
To: malc <av1474@comtv.ru>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3] raw-posix: Detect CDROM via ioctl
Date: Wed, 13 Jan 2010 20:48:38 -0500 [thread overview]
Message-ID: <4B4E77F6.1040205@redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1001140310460.5415@linmac.oyster.ru>
On 01/13/2010 07:11 PM, malc wrote:
> On Wed, 13 Jan 2010, Cole Robinson wrote:
>
>> Current CDROM detection is hardcoded based on source file name.
>> Make this smarter by attempting a CDROM specific ioctl.
>>
>> This makes '-cdrom /dev/sr0' succeed with no media present.
>>
>> v2:
>> Give ioctl check higher priority than filename check,
>>
>> v3:
>> Actually initialize 'prio' variable
>> Check for ioctl success rather than absence of specific failure
>
> Does it even compile on BSDs, Darwin etc?
>
The changed functions are all under #ifdef __linux__, so I assume its fine.
Haven't tested though.
- Cole
next prev parent reply other threads:[~2010-01-14 1:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-13 23:45 [Qemu-devel] [PATCH v3] raw-posix: Detect CDROM via ioctl Cole Robinson
2010-01-14 0:11 ` malc
2010-01-14 1:48 ` Cole Robinson [this message]
2010-01-14 10:45 ` malc
2010-01-14 16:09 ` Cole Robinson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B4E77F6.1040205@redhat.com \
--to=crobinso@redhat.com \
--cc=av1474@comtv.ru \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.