From: Masami Hiramatsu <mhiramat@redhat.com>
To: Li Zefan <lizf@cn.fujitsu.com>
Cc: Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] perf probe: Fix build failure
Date: Thu, 14 Jan 2010 01:20:59 -0500 [thread overview]
Message-ID: <4B4EB7CB.2030807@redhat.com> (raw)
In-Reply-To: <4B4EAA54.9000109@cn.fujitsu.com>
Li Zefan wrote:
> Masami Hiramatsu wrote:
>> Hi,
>>
>> Thank you, the patch code looks good to me.
>>
>> Li Zefan wrote:
>>> builtin-probe.c:121: error: 'opt_show_lines' defined but not used
>>
>> Please add some comment for explanation, like:
>>
>> This build error occurs when compiling perf-tools without dwarf
>> support (no libdwarf).
>>
>
> But as simple as this patch, the code itself has explained
> the cause of this compile error.
If someone looks git-log afterwords, below message seems too
short.
---
perf probe: Fix build failure
builtin-probe.c:121: error: 'opt_show_lines' defined but not used
---
Especially, if there is libdwarf, we will not see above error. So
IMHO, at least we'd better add a comment about how the error occurs.
Thank you,
--
Masami Hiramatsu
Software Engineer
Hitachi Computer Products (America), Inc.
Software Solutions Division
e-mail: mhiramat@redhat.com
next prev parent reply other threads:[~2010-01-14 6:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-14 3:03 [PATCH] perf probe: Fix build failure Li Zefan
2010-01-14 4:51 ` Masami Hiramatsu
2010-01-14 5:23 ` Li Zefan
2010-01-14 6:20 ` Masami Hiramatsu [this message]
2010-01-14 6:30 ` Li Zefan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B4EB7CB.2030807@redhat.com \
--to=mhiramat@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.