Re: [lm-sensors] [RFC PATCH 0/1] Add the sensors-config tool

[Hans de Goede <hdegoede@redhat.com>]

Hi Andre,

Thanks for working on this!

On 01/13/2010 09:56 PM, Andre Prendel wrote:
> Hello Jean, Hans,
>
> a long time ago we've spoken about "DMI-based
> configuration". Unfortunately the last half year I only had a very
> reduced amount of time. But today I send my first proposal (patch) for
> this issue :)
>
> A few words...
>
> The tool is written in Python. I hope you can live with
> this although this is another language in the lm-sensors project. I like
> the object oriented modules of Python and IMHO Python should be
> installed on every machine in a default installation.
>

Hmm, I don't mind the archive download and building tool being written
in python. But eventually there should also be a bash script which
can be run from the systems initscript which will automatically
find a config based on dmi and if found copy it to /etc/sensors-mb.conf
(which can then be included from the regular sensors.conf). I don't
think this part should be in python as on most systems none of the
other initscripts use python.

> What can you do with this tool?
>
> 1. Download config files from lm-sensors.org and build an archive

Hmm, I see it currently has a hardcoded list of config files, it would
be good if it could discover the config files dynamically based on
what is available on lm-sensors.org

> 2. Install this archive into the file system (the path is hard-coded
> so far)

I think the path should be under /var/lib, as the contents can
change by running the same version of the tool again (if the
wiki is updated).

> 3. List the vendors off the available configs
> 4. List the board configs of a vendor
> 5. Install a config by vendor and board name
> 6. Show your systems' DMI data
> 7. Search a config based on the DMI data and install them

I see currently this assumes that the name as on the wiki (in
the url on the wiki), is the same as in the dmi info, this is
not necessarily true. There was a project similar to yours a
while ago, which added magic comments to the config files
to state for which dmi strings the config was valid. note
that one config could be valid for multiple boards.

> 8. Remove the configs from the file system
>
> NOTE: This is an early version. There are plenty of ToDos and probably
> some bugs. This is a request for comments what do you thing about the
> tool.
>

Disclaimer: I have not tested it.

What I think, well I like that someone is working on this, and I like
that you are using the wiki as "database", as with previous attempts
part of the problem was that both a tool and a website needed to
be developed simultaneously.

As for comments, see above.

Thanks & Regards,

Hans

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors