All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jean-Hugues Deschenes <jean-hugues.deschenes-YGVykHU+fedBDgjK7y7TUQ@public.gmane.org>
To: Ben Dooks <ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>
Cc: Baruch Siach <baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org>,
	linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 2/3] Check component type register
Date: Thu, 14 Jan 2010 07:37:44 -0500	[thread overview]
Message-ID: <4B4F1018.6010602@octasic.com> (raw)
In-Reply-To: <20100114011101.GK3738-SMNkleLxa3Z6Wcw2j4pizdi2O/JbrIOy@public.gmane.org>


>> +		if (0x44570140 != comp_type) {
>> +			dev_err(&pdev->dev, "Unknown Synopsys component type: "
>> +					"0x%08x\n",	comp_type);
>> +			r = -ENODEV;
>> +			goto err_iounmap;
>> +		}
>> +	}
>> +	{
>>     
>
> The general convention in linux is to do (if x = constant).
>   
Old coding habits are difficult to get rid of ;-). I'll change it in the 
updated patchset, once all comments have been collected.

thanks,
jh

  parent reply	other threads:[~2010-01-14 12:37 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-13 19:32 [PATCH 0/3] i2c-designware: Allow mixed endianness Jean-Hugues Deschenes
2010-01-13 19:32 ` [PATCH 1/3] Use local version of readl & writel Jean-Hugues Deschenes
     [not found]   ` <20100113193421.068608000-YGVykHU+fedBDgjK7y7TUQ@public.gmane.org>
2010-01-14 23:40     ` Shinya Kuribayashi
     [not found]       ` <4B4FAB83.1060408-jaWZhaxaiAMAvxtiuMwx3w@public.gmane.org>
2010-01-15 13:33         ` Jean-Hugues Deschenes
2010-01-13 19:32 ` [PATCH 2/3] Check component type register Jean-Hugues Deschenes
     [not found]   ` <20100113193421.139644000-YGVykHU+fedBDgjK7y7TUQ@public.gmane.org>
2010-01-14  1:11     ` Ben Dooks
     [not found]       ` <20100114011101.GK3738-SMNkleLxa3Z6Wcw2j4pizdi2O/JbrIOy@public.gmane.org>
2010-01-14 12:37         ` Jean-Hugues Deschenes [this message]
2010-01-13 19:32 ` [PATCH 3/3] Allow mixed endianness accesses Jean-Hugues Deschenes
     [not found]   ` <20100113193421.212989000-YGVykHU+fedBDgjK7y7TUQ@public.gmane.org>
2010-01-15  0:01     ` Shinya Kuribayashi
     [not found]       ` <4B4FB03E.1070708-jaWZhaxaiAMAvxtiuMwx3w@public.gmane.org>
2010-01-15 14:04         ` Jean-Hugues Deschenes
     [not found]           ` <4B5075ED.8020307-YGVykHU+fedBDgjK7y7TUQ@public.gmane.org>
2010-01-15 15:16             ` Jean-Hugues Deschenes
2010-01-18 10:00             ` Shinya Kuribayashi
     [not found]               ` <4B54312E.9030106-jaWZhaxaiAMAvxtiuMwx3w@public.gmane.org>
2010-01-18 12:54                 ` Jean-Hugues Deschenes
     [not found] ` <20100113193224.753273000-YGVykHU+fedBDgjK7y7TUQ@public.gmane.org>
2010-01-14  0:40   ` [PATCH 0/3] i2c-designware: Allow mixed endianness Shinya Kuribayashi
     [not found]     ` <4B4E6815.9050908-jaWZhaxaiAMAvxtiuMwx3w@public.gmane.org>
2010-01-14  1:09       ` Ben Dooks
     [not found]         ` <390831ED3DF58E41A3D2FB82591E2C36047AF627@MAILEXCH.octasic.com>
     [not found]           ` <390831ED3DF58E41A3D2FB82591E2C36047AF627-Jh1kU4MlLDZ5rAAhGZPdxVaTQe2KTcn/@public.gmane.org>
2010-01-14  6:45             ` Ben Dooks
     [not found]               ` <20100114064501.GR3738-SMNkleLxa3Z6Wcw2j4pizdi2O/JbrIOy@public.gmane.org>
2010-01-14 12:34                 ` Jean-Hugues Deschenes
2010-01-14 12:30   ` Baruch Siach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B4F1018.6010602@octasic.com \
    --to=jean-hugues.deschenes-ygvykhu+fedbdgjk7y7tuq@public.gmane.org \
    --cc=baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org \
    --cc=ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.