From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH] USB: musb: allow unaligned memory data transfers Date: Thu, 14 Jan 2010 16:49:18 +0300 Message-ID: <4B4F20DE.6040001@ru.mvista.com> References: <1263310937-7249-1-git-send-email-vikram.pandita@ti.com> <20100114112354.GG19526@nokia.com> <5A47E75E594F054BAF48C5E4FC4B92AB031E2EB521@dbde02.ent.ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5A47E75E594F054BAF48C5E4FC4B92AB031E2EB521-/tLxBxkBPtCIQmiDNMet8wC/G2K4zDHf@public.gmane.org> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "Gadiyar, Anand" Cc: "felipe.balbi-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org" , "Pandita, Vikram" , "linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "Mankad, Maulik Ojas" , "Patra, Nilkesh" List-Id: linux-omap@vger.kernel.org Hello. Gadiyar, Anand wrote: >> From: Felipe Balbi wrote: >> >>> + /* On MUSB:RTL1.8 and above, DMA has to be word aligned */ >>> + if ((dma_addr % 4) && >>> + (musb->hwvers >= MUSB_HWVERS_1800)) { >>> >> is it only inventra dma that suffers from this ? If not, we could move >> this check before even calling the dma routine. >> > > Yes, it's only the integrated Inventra DMA that behaves like this. > > Anyway, I don't think newer versions of the IP are being used by > anyone without the Inventra DMA. The older versions though are > sometimes used with external DMA controllers. DA8xx/OMAP-L1x has MUSB version 1.800 and external, CPPI 4.1 DMA controller. WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html