From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NVRUT-0005mg-S3
	for qemu-devel@nongnu.org; Thu, 14 Jan 2010 10:20:05 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NVRUP-0005j2-S9
	for qemu-devel@nongnu.org; Thu, 14 Jan 2010 10:20:05 -0500
Received: from [199.232.76.173] (port=39953 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NVRUP-0005ih-CX
	for qemu-devel@nongnu.org; Thu, 14 Jan 2010 10:20:01 -0500
Received: from goliath.siemens.de ([192.35.17.28]:18470)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <jan.kiszka@siemens.com>) id 1NVRUO-0004wP-Jd
	for qemu-devel@nongnu.org; Thu, 14 Jan 2010 10:20:01 -0500
Message-ID: <4B4F3618.3020103@siemens.com>
Date: Thu, 14 Jan 2010 16:19:52 +0100
From: Jan Kiszka <jan.kiszka@siemens.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH][STABLE] Don't set default monitor when there
	is a mux'ed one
References: <4B4F2F06.2040301@siemens.com> <4B4F3343.1030809@codemonkey.ws>
In-Reply-To: <4B4F3343.1030809@codemonkey.ws>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Anthony Liguori <aliguori@us.ibm.com>, Gerd Hoffmann <kraxel@redhat.com>, qemu-devel <qemu-devel@nongnu.org>

Anthony Liguori wrote:
> On 01/14/2010 08:49 AM, Jan Kiszka wrote:
>> This fixes eg. "-nographic -serial mon:stdio [-serial ...]".
>>    
> 
> Is this really an appropriate invocation though?
> 
> -nographic != mon:stdio so the semantics of how this is supposed to 
> behave is at best ill-defined.

Original -nographic implied mon:stdio unless you specified your own
-serial. If this was reasonable or not, changing behavior now breaks
tons of scripts.

Actually, there is more legacy breakage in the new default handling. The
missing translation of "-serial stdio -monitor stdio" => "-serial
mon:stdio" can already be harmful to some setups, though I guess they
are less common.

However, this patch addresses something that is a bug outside the scope
of -nographic's semantic.

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux