All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Trimarchi <michael@panicking.kicks-ass.org>
To: "Aguirre, Sergio" <saaguirre@ti.com>
Cc: "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
	akari Ailus <sakari.ailus@maxwell.research.nokia.com>
Subject: [RFC PATCH] fix try_pix_parm loop
Date: Thu, 14 Jan 2010 20:08:18 +0100	[thread overview]
Message-ID: <4B4F6BA2.50402@panicking.kicks-ass.org> (raw)
In-Reply-To: <4B4F56C8.7060108@panicking.kicks-ass.org>

[-- Attachment #1: Type: text/plain, Size: 1 bytes --]



[-- Attachment #2: dont-skip-format.patch --]
[-- Type: text/x-diff, Size: 765 bytes --]

This patch fix try_pix_parm loop that try to find a suitable format for
the isp engine

Signed-off-by: Michael Trimarchi <michael@panicking.kicks-ass.org>
Cc: akari Ailus <sakari.ailus@maxwell.research.nokia.com>
Cc: Sergio Aguirre <saaguirre@ti.com>

---
diff --git a/drivers/media/video/omap34xxcam.c b/drivers/media/video/omap34xxcam.c
index 53b587e..bf7db71 100644
--- a/drivers/media/video/omap34xxcam.c
+++ b/drivers/media/video/omap34xxcam.c
@@ -470,7 +470,7 @@ static int try_pix_parm(struct omap34xxcam_videodev *vdev,
 			pix_tmp_out = *wanted_pix_out;
 			rval = isp_try_fmt_cap(isp, &pix_tmp_in, &pix_tmp_out);
 			if (rval)
-				return rval;
+				continue;
 
 			dev_dbg(&vdev->vfd->dev, "this w %d\th %d\tfmt %8.8x\t"
 				"-> w %d\th %d\t fmt %8.8x"

  reply	other threads:[~2010-01-14 19:08 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-14 12:00 omap34xxcam question? Michael Trimarchi
2010-01-14 17:09 ` Aguirre, Sergio
2010-01-14 17:25   ` Michael Trimarchi
2010-01-14 17:33     ` Aguirre, Sergio
2010-01-14 17:39       ` Michael Trimarchi
2010-01-14 19:08         ` Michael Trimarchi [this message]
2010-01-14 23:57         ` Aguirre, Sergio
2010-01-15  8:38           ` Michael Trimarchi
2010-01-19 17:30             ` Michael Trimarchi
2010-02-04 14:21             ` Sakari Ailus
2010-02-04 15:06               ` Michael Trimarchi
2010-02-05  7:43                 ` Sakari Ailus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B4F6BA2.50402@panicking.kicks-ass.org \
    --to=michael@panicking.kicks-ass.org \
    --cc=linux-media@vger.kernel.org \
    --cc=saaguirre@ti.com \
    --cc=sakari.ailus@maxwell.research.nokia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.