From: Roel Kluin <roel.kluin@gmail.com>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH] [NET]: da.s_net not copied but assigned to itself in aarp_rcv()
Date: Thu, 14 Jan 2010 21:32:11 +0100 [thread overview]
Message-ID: <4B4F7F4B.8000302@gmail.com> (raw)
da.s_net was not copied but assigned to itself.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
diff --git a/net/appletalk/aarp.c b/net/appletalk/aarp.c
index 9d4adfd..f2b3b56 100644
--- a/net/appletalk/aarp.c
+++ b/net/appletalk/aarp.c
@@ -819,7 +819,7 @@ static int aarp_rcv(struct sk_buff *skb, struct net_device *dev,
ma = &ifa->address;
else { /* We need to make a copy of the entry. */
da.s_node = sa.s_node;
- da.s_net = da.s_net;
+ da.s_net = sa.s_net;
ma = &da;
}
next reply other threads:[~2010-01-14 20:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-14 20:32 Roel Kluin [this message]
2010-01-14 21:00 ` [PATCH] [NET]: da.s_net not copied but assigned to itself in aarp_rcv() Arnaldo Carvalho de Melo
2010-01-15 9:49 ` David Miller
2012-03-02 19:34 ` Jonathan Nieder
2012-06-09 7:07 ` [2.6.32.y] Re: [PATCH] appletalk:: " Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B4F7F4B.8000302@gmail.com \
--to=roel.kluin@gmail.com \
--cc=acme@ghostprotocols.net \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.