From: Benoit PAPILLAULT <benoit.papillault@free.fr>
To: "Luis R. Rodriguez" <mcgrof@gmail.com>
Cc: johannes@sipsolutions.net, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: check that ieee80211_set_power_mgmt only handles STA interfaces.
Date: Fri, 15 Jan 2010 02:08:10 +0100 [thread overview]
Message-ID: <4B4FBFFA.3020909@free.fr> (raw)
In-Reply-To: <43e72e891001141652h6830c395ufea7602c009292f2@mail.gmail.com>
Luis R. Rodriguez a écrit :
> On Thu, Jan 14, 2010 at 4:48 PM, Benoit Papillault
> <benoit.papillault@free.fr> wrote:
>> ieee80211_set_power_mgmt is meant for STA interfaces only. Moreover,
>> since sdata->u.mgd.mtx is only initialized for STA interfaces, using
>> this code for any other type of interface (like IBSS) will result in a
>> oops.
>
> Is this path even possible at this point? Is this a stable fix?
>
> Luis
>
This is the case if you create a monitor interface (I wonder why it did
not notice before however). I think we should return -EOPNOTSUPP instead
of 0 (otherwise iwconfig shows "Power management:on" on monitor
interface). As such, this is a stable fix.
Do i need to send an updated patch?
Regards,
Benoit
next prev parent reply other threads:[~2010-01-15 1:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-15 0:48 [PATCH] mac80211: check that ieee80211_set_power_mgmt only handles STA interfaces Benoit Papillault
2010-01-15 0:52 ` Luis R. Rodriguez
2010-01-15 1:08 ` Benoit PAPILLAULT [this message]
2010-01-15 10:17 ` Johannes Berg
-- strict thread matches above, loose matches on Subject: below --
2010-01-15 11:21 Benoit Papillault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B4FBFFA.3020909@free.fr \
--to=benoit.papillault@free.fr \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.