From: Tejun Heo <tj@kernel.org>
To: Jeff Garzik <jeff@garzik.org>
Cc: "linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Hans Werner <hwerner4@gmx.de>,
Sergei Shtylyov <sshtylyov@ru.mvista.com>
Subject: Re: [PATCH #upstream-fixes 1/2] libata: cleanup ata_sff_interrupt()
Date: Fri, 15 Jan 2010 12:33:10 +0900 [thread overview]
Message-ID: <4B4FE1F6.4060204@kernel.org> (raw)
In-Reply-To: <4B4F56A0.6060606@garzik.org>
On 01/15/2010 02:38 AM, Jeff Garzik wrote:
> On 01/14/2010 02:50 AM, Tejun Heo wrote:
>> host->ports[i] is never NULL if i< host->n_ports and non-NULL return
>> from ata_qc_from_tag() guarantees that the returned qc is active.
>> Drop unnecessary tests.
>>
>> Signed-off-by: Tejun Heo<tj@kernel.org>
>> ---
>> drivers/ata/libata-sff.c | 17 +++++++----------
>> 1 file changed, 7 insertions(+), 10 deletions(-)
>
> This is more #upstream material, don't you think? We are pretty deep
> into -rc at this point.
Yeap, agreed.
Thanks.
--
tejun
prev parent reply other threads:[~2010-01-15 3:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-14 7:50 [PATCH #upstream-fixes 1/2] libata: cleanup ata_sff_interrupt() Tejun Heo
2010-01-14 7:53 ` [PATCH #upstream-fixes 2/2] libata: implement spurious irq handling for SFF and apply it to piix Tejun Heo
2010-01-14 12:42 ` Sergei Shtylyov
2010-01-15 3:39 ` Tejun Heo
2010-01-15 10:23 ` Sergei Shtylyov
2010-01-15 21:45 ` Tejun Heo
2010-01-14 10:20 ` [PATCH #upstream-fixes 1/2] libata: cleanup ata_sff_interrupt() Sergei Shtylyov
2010-01-15 3:36 ` Tejun Heo
2010-01-14 17:38 ` Jeff Garzik
2010-01-15 3:33 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B4FE1F6.4060204@kernel.org \
--to=tj@kernel.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=hwerner4@gmx.de \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.