Re: [PATCH #upstream-fixes 2/2] libata: implement spurious irq handling for SFF and apply it to piix

[Sergei Shtylyov <sshtylyov@ru.mvista.com>]

Hello.

Tejun Heo wrote:

>>> +static bool piix_irq_check(struct ata_port *ap)
>>> +{
>>> +    if (unlikely(!ap->ioaddr.bmdma_addr))
>>> +        return false;
>>> +
>>> +    return ap->ops->bmdma_status(ap) & ATA_DMA_INTR;
>>> +}
>>> +
>>>   
>>>       
>>   I'm not at all sure that old, pre-ICH controllers set this bit also
>> for the PIO mode commands, not only for DMA. And if you didn't make such
>> assumption, I don't see why this can't be generic and placed into
>> libata-sff.c instead...
>>     
>
> Because different controllers have different mechanisms for detecting
> pending IRQ?

   All SFF-8038i (BMIDE) controllers have the same mechanism. They may 
have some additional interrupt bits though, reflecting the interrupt 
status in both PIO and DMA mode though.

WBR, Sergei