All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steve Dickson <SteveD@redhat.com>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: chris.mason@oracle.com, linux-nfs@vger.kernel.org
Subject: Re: [PATCH 0/6] IPv6 support for nfs-utils tcpwrapper shim
Date: Fri, 15 Jan 2010 14:32:41 -0500	[thread overview]
Message-ID: <4B50C2D9.3020305@RedHat.com> (raw)
In-Reply-To: <479E585D-C511-4B89-B2E4-A57E3EA2B7E8@oracle.com>



On 01/15/2010 01:59 PM, Chuck Lever wrote:
> On Jan 15, 2010, at 1:37 PM, Steve Dickson wrote:
>> On 01/15/2010 01:27 PM, Chuck Lever wrote:
>>> On Jan 15, 2010, at 1:04 PM, Steve Dickson wrote:
>>>> On 01/15/2010 12:49 PM, Chuck Lever wrote:
>>>>> These patches provide IPv6 support for the tcpwrapper shim inside
>>>>> nfs-utils.  It assumes that the generic tcpwrapper library can
>>>>> support IPv6 addresses.  It has not been extensively tested, but
>>>>> I think the framework is reasonable, and only minor bug fixes might
>>>>> be needed as we go along.
>>>> Did you do any simple "hello world" testing?
>>>
>>> I've build-tested them.  Jeff and I had them applied while doing the
>>> statd testing.  They don't appear to cause problems when no allow/deny
>>> sets exist.
>>>
>>> I thought we would have more time to test and review these, so I haven't
>>> done more extensive testing so far.  In any case, I don't think they
>>> will be harmful, and can serve as a place marker for that feature as the
>>> beta moves forward.
>> Unfortunately I have broken these before and it was awful painful... :-(
>> Right or wrong... there is still a large number of people that depend
>> on this archaic routines... we need to be very careful...
> 
> Do you have tests I can run to validate these patches to your satisfaction?
No... I wish I did... I just do the testing by hand... 

steved.

      reply	other threads:[~2010-01-15 19:32 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-15 17:49 [PATCH 0/6] IPv6 support for nfs-utils tcpwrapper shim Chuck Lever
     [not found] ` <20100115174426.30104.3492.stgit-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2010-01-15 17:49   ` [PATCH 1/6] tcpwrappers: Use xlog() instead of perror(3) and syslog(2) Chuck Lever
2010-01-15 17:49   ` [PATCH 2/6] tcp_wrappers: Use getifaddrs(3) if it is available Chuck Lever
2010-01-15 17:49   ` [PATCH 3/6] tcp_wrapper: Clean up logit() Chuck Lever
2010-01-15 17:50   ` [PATCH 4/6] tcpwrapper: Fix signage problems in the tcp_wrappers hash function Chuck Lever
2010-01-15 17:50   ` [PATCH 5/6] tcpwrapper: Eliminated shadowed declaration warnings Chuck Lever
2010-01-15 17:50   ` [PATCH 6/6] tcpwrapper: Add support for IPv6 Chuck Lever
2010-01-15 18:04   ` [PATCH 0/6] IPv6 support for nfs-utils tcpwrapper shim Steve Dickson
     [not found]     ` <4B50AE34.3020009-AfCzQyP5zfLQT0dZR+AlfA@public.gmane.org>
2010-01-15 18:27       ` Chuck Lever
2010-01-15 18:37         ` Steve Dickson
     [not found]           ` <4B50B5F0.6020202-AfCzQyP5zfLQT0dZR+AlfA@public.gmane.org>
2010-01-15 18:59             ` Chuck Lever
2010-01-15 19:32               ` Steve Dickson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B50C2D9.3020305@RedHat.com \
    --to=steved@redhat.com \
    --cc=chris.mason@oracle.com \
    --cc=chuck.lever@oracle.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.