Re: [Xenomai-core] [PATCH xenomai-2.5 0/3] rtcan: mscan: new OF platform driver for MPC521x and MPC5200

[Gilles Chanteperdrix <gilles.chanteperdrix@xenomai.org>]

Wolfgang Grandegger wrote:
> Hi Gilles
> 
> Gilles Chanteperdrix wrote:
>> Wolfgang Grandegger wrote:
>>> Gilles Chanteperdrix wrote:
>>>> Wolfgang Grandegger wrote:
>>>>> From: Wolfgang Grandegger <wg@domain.hid>
>>>>>
>>>>> This patch series adds RT-Socket-CAN support for the MSCAN on the MPC512x
>>>>> from Freescale by introducing a new OF platform driver for both, the
>>>>> MPC521x and MPC5200, while still keeping the old driver for the MPC5200
>>>>> for compatibility with older kernel versions.
>>>> Hi Wolfgang,
>>>>
>>>> there seems to be something missing, because I get a compilation error
>>>> on lite-5200:
>>>> http://sisyphus.hd.free.fr/~gilles/bx/#powerpc
>>> Well, I obviously did not test the driver with old versions of the Linux
>>> kernel, sorry. 
>> No problem, that is what the build test is for.
>>
>>
>>> For 2.6.29 and 2.6.30 the following patch should fix the build:
>> Ok. I applied a slightly different modification (fixing in wrappers.h).
>> I am waiting for your fix for 2.4 for pushing.
> 
> See patch below. It will contain your fixes in wrappers.h. I will do some
> final testing on real hardware on monday.

All green, pushed. Only with one change: I removed the explicit
inclusion of wrappers.h in rtcan_mscan_mpc52xx.c, as it is already
included thanks to rtdm_driver.h, and Jan told us that we should not do
that if we want the code to be compiled for rtdm-native.

-- 
					    Gilles.