All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom <Tom.Rix@windriver.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Add support for MB86R01 from Fujitsu
Date: Sat, 16 Jan 2010 09:39:01 -0600	[thread overview]
Message-ID: <4B51DD95.10004@windriver.com> (raw)
In-Reply-To: <1263230330-19728-2-git-send-email-matthias.weisser@graf-syteco.de>

Matthias Weisser wrote:
> Signed-off-by: Matthias Weisser <matthias.weisser@graf-syteco.de>
> ---
>  common/serial.c                      |    3 +-
>  cpu/arm926ejs/jade/Makefile          |   47 +++++++++
>  cpu/arm926ejs/jade/reset.c           |   37 ++++++++
>  cpu/arm926ejs/jade/timer.c           |  127 +++++++++++++++++++++++++
>  include/asm-arm/arch-jade/hardware.h |   31 ++++++
>  include/asm-arm/arch-jade/jade.h     |  170 ++++++++++++++++++++++++++++++++++
>  include/serial.h                     |    3 +-
>  7 files changed, 416 insertions(+), 2 deletions(-)
>  create mode 100644 cpu/arm926ejs/jade/Makefile
>  create mode 100644 cpu/arm926ejs/jade/reset.c
>  create mode 100644 cpu/arm926ejs/jade/timer.c
>  create mode 100644 include/asm-arm/arch-jade/hardware.h
>  create mode 100644 include/asm-arm/arch-jade/jade.h
> 
> diff --git a/common/serial.c b/common/serial.c
> index 5f9ffd7..7397608 100644
> --- a/common/serial.c
> +++ b/common/serial.c
> @@ -41,7 +41,8 @@ struct serial_device *__default_serial_console (void)
>  #elif defined(CONFIG_405GP) || defined(CONFIG_405CR) || defined(CONFIG_440) \
>     || defined(CONFIG_405EP) || defined(CONFIG_405EZ) || defined(CONFIG_405EX) \
>     || defined(CONFIG_MPC5xxx) || defined(CONFIG_MPC83xx) \
> -   || defined(CONFIG_MPC85xx) || defined(CONFIG_MPC86xx)
> +   || defined(CONFIG_MPC85xx) || defined(CONFIG_MPC86xx) \
> +   || defined(CONFIG_JADE)
>  #if defined(CONFIG_CONS_INDEX) && defined(CONFIG_SYS_NS16550_SERIAL)
>  #if (CONFIG_CONS_INDEX==1)
>  	return &eserial1_device;

Including serial here is premature.
I do not see where you set up there serial devices.
Please save this for a later serial-only patch.

Otherwise this patch looks fine.
Tom

  parent reply	other threads:[~2010-01-16 15:39 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-11 17:18 [U-Boot] Adding support for MB86R01 Matthias Weisser
2010-01-11 17:18 ` [U-Boot] [PATCH] Add support for MB86R01 from Fujitsu Matthias Weisser
2010-01-11 17:18   ` [U-Boot] [PATCH] Add support for Jade display controller Matthias Weisser
2010-01-11 17:18     ` [U-Boot] [PATCH] Adding new vendor logo Matthias Weisser
2010-01-11 17:18       ` [U-Boot] [PATCH] Add support for jadecpu board Matthias Weisser
2010-01-16 19:18         ` Tom
2010-01-16 20:11           ` Wolfgang Denk
2010-01-18  7:05             ` [U-Boot] Antw: " Matthias Weisser
2010-01-18  7:57               ` Wolfgang Denk
2010-01-18  8:21                 ` Matthias Weißer
2010-01-18  8:55                   ` Wolfgang Denk
2010-01-18  7:54           ` [U-Boot] " Matthias Weißer
2010-01-18  8:52             ` Wolfgang Denk
2010-01-18 12:10               ` Matthias Weißer
2010-01-18 13:11                 ` Tom
2010-01-21 19:52                 ` Tom
2010-01-16 16:43       ` [U-Boot] [PATCH] Adding new vendor logo Tom
2010-01-18 13:55         ` Matthias Weißer
2010-01-16 16:30     ` [U-Boot] [PATCH] Add support for Jade display controller Tom
2010-01-18 14:06       ` Matthias Weißer
2010-01-16 15:39   ` Tom [this message]
2010-01-18 14:01     ` [U-Boot] [PATCH] Add support for MB86R01 from Fujitsu Matthias Weißer
2010-01-16 15:40 ` [U-Boot] Adding support for MB86R01 Tom

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B51DD95.10004@windriver.com \
    --to=tom.rix@windriver.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.