From mboxrd@z Thu Jan  1 00:00:00 1970
Message-ID: <4B5223BD.5050703@domain.hid>
Date: Sat, 16 Jan 2010 21:38:21 +0100
From: Wolfgang Grandegger <wg@domain.hid>
MIME-Version: 1.0
References: <1263470867-1533-1-git-send-email-wg@domain.hid>
	<4B5076F9.40508@domain.hid> <4B507B06.4080206@domain.hid>
	<4B50AF89.1000909@domain.hid> <4B50D9C7.8090901@domain.hid>
	<4B5188DC.4080606@domain.hid>
In-Reply-To: <4B5188DC.4080606@domain.hid>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Xenomai-core] [PATCH xenomai-2.5 0/3] rtcan: mscan: new
 OF	platform driver for MPC521x and MPC5200
List-Id: Xenomai life and development <xenomai.xenomai.org>
List-Unsubscribe: <https://mail.gna.org/listinfo/xenomai-core>,
	<mailto:xenomai-core-request@domain.hid>
List-Archive: </public/xenomai-core>
List-Post: <mailto:xenomai@xenomai.org>
List-Help: <mailto:xenomai-core-request@domain.hid>
List-Subscribe: <https://mail.gna.org/listinfo/xenomai-core>,
	<mailto:xenomai-core-request@domain.hid>
To: Gilles Chanteperdrix <gilles.chanteperdrix@xenomai.org>
Cc: Xenomai-core@domain.hid, Wolfgang Grandegger <wg@domain.hid>

Gilles Chanteperdrix wrote:
> Wolfgang Grandegger wrote:
>> Hi Gilles
>>
>> Gilles Chanteperdrix wrote:
>>> Wolfgang Grandegger wrote:
>>>> Gilles Chanteperdrix wrote:
>>>>> Wolfgang Grandegger wrote:
>>>>>> From: Wolfgang Grandegger <wg@domain.hid>
>>>>>>
>>>>>> This patch series adds RT-Socket-CAN support for the MSCAN on the MPC512x
>>>>>> from Freescale by introducing a new OF platform driver for both, the
>>>>>> MPC521x and MPC5200, while still keeping the old driver for the MPC5200
>>>>>> for compatibility with older kernel versions.
>>>>> Hi Wolfgang,
>>>>>
>>>>> there seems to be something missing, because I get a compilation error
>>>>> on lite-5200:
>>>>> http://sisyphus.hd.free.fr/~gilles/bx/#powerpc
>>>> Well, I obviously did not test the driver with old versions of the Linux
>>>> kernel, sorry. 
>>> No problem, that is what the build test is for.
>>>
>>>
>>>> For 2.6.29 and 2.6.30 the following patch should fix the build:
>>> Ok. I applied a slightly different modification (fixing in wrappers.h).
>>> I am waiting for your fix for 2.4 for pushing.
>> See patch below. It will contain your fixes in wrappers.h. I will do some
>> final testing on real hardware on monday.
> 
> All green, pushed. Only with one change: I removed the explicit
> inclusion of wrappers.h in rtcan_mscan_mpc52xx.c, as it is already
> included thanks to rtdm_driver.h, and Jan told us that we should not do
> that if we want the code to be compiled for rtdm-native.

And it is not even needed, as I just verified.

Thanks,

Wolfgang.