From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1NWTqU-0005vH-St for mharc-grub-devel@gnu.org; Sun, 17 Jan 2010 07:03:06 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NWTqS-0005uZ-PC for grub-devel@gnu.org; Sun, 17 Jan 2010 07:03:04 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NWTqO-0005ss-9u for grub-devel@gnu.org; Sun, 17 Jan 2010 07:03:04 -0500 Received: from [199.232.76.173] (port=36931 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NWTqO-0005sn-1H for grub-devel@gnu.org; Sun, 17 Jan 2010 07:03:00 -0500 Received: from fg-out-1718.google.com ([72.14.220.155]:38307) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NWTqN-0000ah-9Q for grub-devel@gnu.org; Sun, 17 Jan 2010 07:02:59 -0500 Received: by fg-out-1718.google.com with SMTP id e21so314266fga.12 for ; Sun, 17 Jan 2010 04:02:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :x-enigmail-version:content-type; bh=MSh6jcVv/0/03cwclDiIzoOs6NYPDu7jKLOrNgeTz6s=; b=b60b7nBebBeQnt/SMjyp075LbwBQsBE8oU/zctVFobduAiWLueUd3gvnIN0E0ZBCoO 0Z2ndT4Zetn24ropM3OVkvdtVjJjbzefe2ycMWTdWdhpZtMpnw/nf7D7kmhcKMRL3NDV 3GAhNZhfColrqY6qSdNAtnoOGSMOg4x8Nnei0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type; b=p/Fsdccsqzpoe7lU+GFfNBrC9Ytt+3T6r5SXJJX4XnwvukTfHJR16v5UyY4AGp72FG Iq/dQleOMZ5AZp8IrwSYvKfuBBGSp+1C04mdFqm5sEiroF26IEl7hPBc4BwJRbfCPl6e bsuRJEh2yg83Tdj0gGV1IPZXprejwZJHFJyKY= Received: by 10.87.62.20 with SMTP id p20mr5884536fgk.7.1263729777406; Sun, 17 Jan 2010 04:02:57 -0800 (PST) Received: from debian.bg45.phnet (144-116.203-62.cust.bluewin.ch [62.203.116.144]) by mx.google.com with ESMTPS id d6sm7137575fga.29.2010.01.17.04.02.56 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sun, 17 Jan 2010 04:02:56 -0800 (PST) Message-ID: <4B52FC6F.5060100@gmail.com> Date: Sun, 17 Jan 2010 13:02:55 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla-Thunderbird 2.0.0.22 (X11/20091109) MIME-Version: 1.0 To: The development of GNU GRUB References: <4B39CC24.9060607@gmail.com> <20100101093222.GU5847@riva.ucam.org> <20100101115256.GG3692@thorin> In-Reply-To: <20100101115256.GG3692@thorin> X-Enigmail-Version: 0.95.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enig2B681F299887587218C98119" X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: [PATCH] switch from sprintf to asprintf and snprintf X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Jan 2010 12:03:05 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig2B681F299887587218C98119 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Robert Millan wrote: > On Fri, Jan 01, 2010 at 09:32:24AM +0000, Colin Watson wrote: > =20 >> On Tue, Dec 29, 2009 at 10:30:12AM +0100, Vladimir '=CF=86-coder/phcod= er' Serbinenko wrote: >> =20 >>> +char *EXPORT_FUNC(grub_asprintf) (const char *fmt, ...) >>> + __attribute__ ((format (printf, 1, 2))); >>> =20 >> It's very confusing that you've made grub_asprintf have a dramatically= >> different interface from asprintf. Perhaps you could call this >> grub_xasprintf instead? >> =20 > > Is it feasible to implement the same interface as asprintf instead? > > =20 it's feasible but the only advantage it gives is the return value nobody uses anyway --=20 Regards Vladimir '=CF=86-coder/phcoder' Serbinenko --------------enig2B681F299887587218C98119 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iF4EAREKAAYFAktS/G8ACgkQNak7dOguQgn/9wEAhzem+wj10PyVMsOQuFBa6vPI RNwFqHuksMKNAIoE6+wA/0nZwzW2W3rzTI4jXhQgw8NA3KL6GvKneViRCr/XaFNZ =Oyze -----END PGP SIGNATURE----- --------------enig2B681F299887587218C98119--