From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCHv2 3/4] Add HYPER-V apic access MSRs. Date: Sun, 17 Jan 2010 14:48:08 +0200 Message-ID: <4B530708.1050006@redhat.com> References: <1263719028-24765-1-git-send-email-gleb@redhat.com> <1263719028-24765-4-git-send-email-gleb@redhat.com> <4B530090.50506@redhat.com> <20100117123232.GA10114@infradead.org> <20100117124142.GC31692@redhat.com> <20100117124457.GA19553@infradead.org> <20100117124654.GE31692@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Christoph Hellwig , mtosatti@redhat.com, kvm@vger.kernel.org To: Gleb Natapov Return-path: Received: from mx1.redhat.com ([209.132.183.28]:33088 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750858Ab0AQMsQ (ORCPT ); Sun, 17 Jan 2010 07:48:16 -0500 In-Reply-To: <20100117124654.GE31692@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 01/17/2010 02:46 PM, Gleb Natapov wrote: > On Sun, Jan 17, 2010 at 07:44:57AM -0500, Christoph Hellwig wrote: > >> On Sun, Jan 17, 2010 at 02:41:42PM +0200, Gleb Natapov wrote: >> >>> I copied code from the instead of using helper faction for >>> some unknown to me reason. Anyway if I can't get struct page from >>> user virtual address I can't use it. Actually I am not sure the page >>> should be zeroed at all. Spec only descries first dword of the page and >>> doesn't require zeroing the reset as far as I see. >>> >> There's a clear_user() function that just takes a user virtual address >> and a size. >> > Precisely what I need. Thanks! > > But clear_user_page() is confusingly named. I assume it deals with virtually tagged caches on archs that have them? -- error compiling committee.c: too many arguments to function