From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCHv2 3/4] Add HYPER-V apic access MSRs. Date: Sun, 17 Jan 2010 14:53:03 +0200 Message-ID: <4B53082F.60209@redhat.com> References: <1263719028-24765-1-git-send-email-gleb@redhat.com> <1263719028-24765-4-git-send-email-gleb@redhat.com> <4B530090.50506@redhat.com> <20100117123626.GB31692@redhat.com> <4B5306B6.8050603@redhat.com> <20100117125013.GF31692@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: mtosatti@redhat.com, kvm@vger.kernel.org To: Gleb Natapov Return-path: Received: from mx1.redhat.com ([209.132.183.28]:42001 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752165Ab0AQMxH (ORCPT ); Sun, 17 Jan 2010 07:53:07 -0500 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o0HCr4PZ028283 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sun, 17 Jan 2010 07:53:04 -0500 In-Reply-To: <20100117125013.GF31692@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 01/17/2010 02:50 PM, Gleb Natapov wrote: >>>> I prefer putting this in x86.c (maybe later split into hyperv.c). >>>> >>>> >>> This implements part of apic behaviour. It uses internal lapic functions >>> like apic_reg_read()/apic_reg_write(). Why move it from lapic.c? >>> >> The new functions implement hyper-v behaviour. Why scatter them all around? >> >> > Each hyper-v extension is pretty much independent one from another, so > why not group things by functionality instead. All apic related code in > lapic.c. > > >> Maybe apic_reg_{read,write} need to be exported. >> >> > This is really internal API. It doesn't even check if apic is created. > Okay. We can rethink it later when the code grows some more. -- error compiling committee.c: too many arguments to function