From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NWVIb-0007lZ-4t for qemu-devel@nongnu.org; Sun, 17 Jan 2010 08:36:13 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NWVIW-0007kh-FW for qemu-devel@nongnu.org; Sun, 17 Jan 2010 08:36:12 -0500 Received: from [199.232.76.173] (port=33476 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NWVIW-0007kd-BK for qemu-devel@nongnu.org; Sun, 17 Jan 2010 08:36:08 -0500 Received: from moutng.kundenserver.de ([212.227.126.187]:53582) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NWVIV-0002rH-Mv for qemu-devel@nongnu.org; Sun, 17 Jan 2010 08:36:08 -0500 Message-ID: <4B531244.6060702@mail.berlios.de> Date: Sun, 17 Jan 2010 14:36:04 +0100 From: Stefan Weil MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] Check for sdl-config before calling it References: <20100117124528.GA24106@bee.dooz.org> In-Reply-To: <20100117124528.GA24106@bee.dooz.org> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 8bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-15?Q?Lo=EFc_Minier?= Cc: qemu-devel@nongnu.org Loïc Minier schrieb: > Hi > > On systems were sdl-config isn't installed, ./configure triggers this > warning: > ./configure: 957: sdl-config: not found > > The attached patch fixes the warning for me. > > Thanks, Hi, which version did you test? Git master has no sdl-config call at configure:957. But I get warning messages, too, when pkg-config or sdl-config are missing. Your patch fixes the warning for sdl-config and sets sdl=no. If configure was called with --enable-sdl, this solution is wrong: configure should abort with an error message (feature_not_found). Regards, Stefan