From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2 1/9] mkimage: Add Freescale imx Boot Image support (imximage)
Date: Mon, 18 Jan 2010 07:27:44 +0100 [thread overview]
Message-ID: <4B53FF60.3020506@denx.de> (raw)
In-Reply-To: <20100115153928.6FA873F6DA@gemini.denx.de>
Wolfgang Denk wrote:
> Dear Stefano Babic,
>
Hi Wolfgang,
>
> Line to long. And please try to stick with a consistent error message
> format.
I see I have too long lines in all patches I have sent. I check this
issue for all of them.
>> + return (params->dflag && (params->fflag || params->lflag)) ||
>> + (params->fflag && (params->dflag || params->lflag)) ||
>> + (params->lflag && (params->dflag || params->fflag)) ||
>> + (params->xflag) || !(strlen(params->imagename));
>
> I cannot understand this code.
Well, I will try to simplify this check and, if not possible, I add
comments to explain what the code is doing.
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
prev parent reply other threads:[~2010-01-18 6:27 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-13 9:50 [U-Boot] MX51 Support V2 Stefano Babic
2010-01-13 9:50 ` [U-Boot] [PATCH V2 1/9] mkimage: Add Freescale imx Boot Image support (imximage) Stefano Babic
2010-01-13 9:50 ` [U-Boot] [PATCH V2 2/9] MX51: Add initial support for the Freescale MX51 Stefano Babic
2010-01-13 9:50 ` [U-Boot] [PATCH V2 3/9] MX51: Add register definitions Stefano Babic
2010-01-13 9:50 ` [U-Boot] [PATCH V2 4/9] MX51: Add pin and multiplexer definitions Stefano Babic
2010-01-13 9:50 ` [U-Boot] [PATCH V2 5/9] serial_mxc: add support for MX51 processor Stefano Babic
2010-01-13 9:50 ` [U-Boot] [PATCH V2 6/9] fec_mxc: " Stefano Babic
2010-01-13 9:50 ` [U-Boot] [PATCH V2 7/9] fsl_esdhc: add support for mx51 processor Stefano Babic
2010-01-13 9:50 ` [U-Boot] [PATCH V2 8/9] mmc: check correctness of the voltage mask in ocr Stefano Babic
2010-01-13 9:50 ` [U-Boot] [PATCH V2 9/9] Add initial support for Freescale mx51evk board Stefano Babic
2010-01-19 8:26 ` [U-Boot] [PATCH V2 7/9] fsl_esdhc: add support for mx51 processor Andy Fleming
2010-01-20 9:33 ` Stefano Babic
2010-01-13 17:08 ` [U-Boot] [PATCH V2 1/9] mkimage: Add Freescale imx Boot Image support (imximage) Fabio Estevam
2010-01-14 8:51 ` Stefano Babic
2010-01-15 0:56 ` Fabio Estevam
2010-01-15 8:40 ` stefano at babic.homelinux.org
2010-01-15 12:19 ` Fabio Estevam
2010-01-15 15:01 ` Stefano Babic
2010-01-15 15:39 ` Wolfgang Denk
2010-01-18 6:27 ` Stefano Babic [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B53FF60.3020506@denx.de \
--to=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.