From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NWokC-0006lv-1c
	for qemu-devel@nongnu.org; Mon, 18 Jan 2010 05:22:00 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NWok7-0006ju-Eg
	for qemu-devel@nongnu.org; Mon, 18 Jan 2010 05:21:59 -0500
Received: from [199.232.76.173] (port=36759 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NWok6-0006jm-Mz
	for qemu-devel@nongnu.org; Mon, 18 Jan 2010 05:21:54 -0500
Received: from fmmailgate02.web.de ([217.72.192.227]:42063)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <jan.kiszka@web.de>) id 1NWok4-0006ur-6a
	for qemu-devel@nongnu.org; Mon, 18 Jan 2010 05:21:54 -0500
Message-ID: <4B543618.9030602@web.de>
Date: Mon, 18 Jan 2010 11:21:12 +0100
From: Jan Kiszka <jan.kiszka@web.de>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH][STABLE] Fix corner case in chardev udp:
	parameter
References: <4B50CAEA.6070900@web.de> <4B5428C5.4050309@redhat.com>
In-Reply-To: <4B5428C5.4050309@redhat.com>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="------------enig827B721FE4D489EC93B0627A"
Sender: jan.kiszka@web.de
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, qemu-devel <qemu-devel@nongnu.org>

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig827B721FE4D489EC93B0627A
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable

Gerd Hoffmann wrote:
> On 01/15/10 21:07, Jan Kiszka wrote:
>> The missing '@' broke 'udp::<port>@:<port>' parsing.
>=20
>>           if (sscanf(p, "%64[^:]:%32[^@,]%n", host, port,&pos)<  2) {
>>               host[0] =3D 0;
>> -            if (sscanf(p, ":%32[^,]%n", port,&pos)<  1) {
>> +            if (sscanf(p, ":%32[^@,]%n", port,&pos)<  1) {
>=20
> Indeed.
>=20
>>                   fprintf(stderr, "udp #1\n");
>=20
> While you are at it, can you also zap this debug leftover?

Looks like there are three of them in qemu_chr_parse_compat - kill them a=
ll?

Jan


--------------enig827B721FE4D489EC93B0627A
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iEYEARECAAYFAktUNh4ACgkQitSsb3rl5xQAkQCfWYX6UW9gsTXevdk+upoKsy3R
7nAAn0F1EaveFbNQkfjbRIDmQIey0Yxo
=NlsD
-----END PGP SIGNATURE-----

--------------enig827B721FE4D489EC93B0627A--