From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH][STABLE-0.12] qemu-kvm: Disable cpu_set command to avoid segfault Date: Mon, 18 Jan 2010 13:34:21 +0200 Message-ID: <4B54473D.4040700@redhat.com> References: <1263230822-17703-1-git-send-email-ozaki.ryota@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, Gleb Natapov , "Daniel P. Berrange" To: Ryota Ozaki Return-path: Received: from mx1.redhat.com ([209.132.183.28]:58493 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751042Ab0ARLeX (ORCPT ); Mon, 18 Jan 2010 06:34:23 -0500 In-Reply-To: <1263230822-17703-1-git-send-email-ozaki.ryota@gmail.com> Sender: kvm-owner@vger.kernel.org List-ID: On 01/11/2010 07:27 PM, Ryota Ozaki wrote: > CPU hotplug feature is lost in this version. Even worse > cpu_set qemu command may cause segfault. > > This patch fix the problem by just disabling it. It is > enough for the stable branch. > > Signed-off-by: Ryota Ozaki > Cc: Gleb Natapov > --- > monitor.c | 4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > diff --git a/monitor.c b/monitor.c > index 6ff6e1f..4b566d2 100644 > --- a/monitor.c > +++ b/monitor.c > @@ -829,7 +829,9 @@ static void do_cpu_set_nr(Monitor *mon, const QDict *qdict) > return; > } > #if defined(TARGET_I386) || defined(TARGET_X86_64) > - qemu_system_cpu_hot_add(value, state); > + //qemu_system_cpu_hot_add(value, state); > + monitor_printf(mon, "The feature is not avaiable in this version. " > + "It will be back in a future version.\n"); > #endif > } > Daniel, how is libvirt going to react to this? -- error compiling committee.c: too many arguments to function