From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH][STABLE-0.12] qemu-kvm: Disable cpu_set command to avoid segfault Date: Mon, 18 Jan 2010 13:57:04 +0200 Message-ID: <4B544C90.5030101@redhat.com> References: <1263230822-17703-1-git-send-email-ozaki.ryota@gmail.com> <4B54473D.4040700@redhat.com> <20100118114920.GH4704@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Ryota Ozaki , kvm@vger.kernel.org, Gleb Natapov To: "Daniel P. Berrange" Return-path: Received: from mx1.redhat.com ([209.132.183.28]:24117 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754117Ab0ARL5I (ORCPT ); Mon, 18 Jan 2010 06:57:08 -0500 In-Reply-To: <20100118114920.GH4704@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 01/18/2010 01:49 PM, Daniel P. Berrange wrote: > >> Daniel, how is libvirt going to react to this? >> > At this precise point in time it won't react since its not using it, but > in a week's time when we have finished the libvirt code to use 'cpu_set' > it'll be less happy ! > > Can't we actually fix CPU hotplug in the stable tree rather than just > commenting it out ? > We should certainly fix it, but I doubt it's a good fit for the stable tree. Gleb, what would it take? -- error compiling committee.c: too many arguments to function