From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1NWt5r-0002jE-CS for mharc-grub-devel@gnu.org; Mon, 18 Jan 2010 10:00:39 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NWt5p-0002ix-R5 for grub-devel@gnu.org; Mon, 18 Jan 2010 10:00:37 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NWt5m-0002hI-1o for grub-devel@gnu.org; Mon, 18 Jan 2010 10:00:37 -0500 Received: from [199.232.76.173] (port=42019 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NWt5l-0002h4-AD for grub-devel@gnu.org; Mon, 18 Jan 2010 10:00:33 -0500 Received: from mail-fx0-f228.google.com ([209.85.220.228]:50220) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NWt5k-0001lq-Ok for grub-devel@gnu.org; Mon, 18 Jan 2010 10:00:33 -0500 Received: by fxm28 with SMTP id 28so981653fxm.26 for ; Mon, 18 Jan 2010 07:00:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :x-enigmail-version:content-type; bh=ISEc5jB+2cwey3jteO+/aza24aAWJAadmVjmhb87e/s=; b=vdOEfVr15S9ycCOEWkgtX1dMEmIvw8ff+MbHXC/v1G1N7VULsjoZvkAZsi8GOjjiqH QbsM+IZ+nRyaEkoqgA8Y+GirO0SRnxlPfqivxV91Cta42iAtmbfNfJTeQC4wh8+6edi+ YFG8wDu+4pgBh9CG0taoepJa3C8QYHLV2Mdf0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type; b=ad/vSqhyCtcfKAiHcJTmqoDWv4fevxzrAOWQ3mRR046S9CK9EfTTnPcgsBxd5G0t/V DB4/o6NIminpD8vNn6LqH+jGZDaO3ujU+j0UHi4H/svjg/5jZBYS40W20t8yjGvUOt2S XwtzzeAQqahYhHx7xJpZsgkpXOoWga+Dwq3WM= Received: by 10.87.15.22 with SMTP id s22mr4922886fgi.56.1263826831720; Mon, 18 Jan 2010 07:00:31 -0800 (PST) Received: from debian.bg45.phnet (252-249.2-85.cust.bluewin.ch [85.2.249.252]) by mx.google.com with ESMTPS id e3sm12760732fga.21.2010.01.18.07.00.30 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 18 Jan 2010 07:00:30 -0800 (PST) Message-ID: <4B547786.7050509@gmail.com> Date: Mon, 18 Jan 2010 16:00:22 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla-Thunderbird 2.0.0.22 (X11/20091109) MIME-Version: 1.0 To: The development of GNU GRUB References: <20100118001016.GA12122@pina.cat> <4B54600A.4050904@gmail.com> <20100118135335.GA28365@pinux.info> In-Reply-To: <20100118135335.GA28365@pinux.info> X-Enigmail-Version: 0.95.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enigFE9B012F3800DA784C535BE3" X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: keyboard layout patches X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Jan 2010 15:00:38 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigFE9B012F3800DA784C535BE3 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Carles Pina i Estany wrote: > Hi, > > I answer in fast way... more at evening. Items that I don't comment I > understand and agree. > > On Jan/18/2010, Vladimir '??-coder/phcoder' Serbinenko wrote: > > =20 >>> How could grub-mkinstall (00_header.in) know the current keyboard in = the >>> system?=20 >>> =20 >> setxkbmap -print will give you the x layout but it won't work outside = of X. >> =20 >>> I wold tweak 00_header.in to generate the keymap file and setup >>> it. >>> =20 >>> =20 >> It may be executed by a daemon with no X available. >> =20 > > I'll use Felix suggestion: do whatever is in /etc/grub/default > > > =20 >> + filename =3D >> + grub_malloc (grub_strlen (prefix) + grub_strlen ("/") + >> + grub_strlen (args[0]) + 1); >> Can you add support for complete filenames? >> =20 > > do you mean that, for example, if args[0] starts by "/" then filename =3D= > args[0]? > > Actually if prefix (that it's a variable) is "/" then args[0] acts as a= > filename. Would be like "///test/filename" and it's a valid directory.= > > =20 Perhaps we should remove prefix variables altogether. >> Can you think of a way to restoring keyboard map to English? >> =20 > > unloading the module restores the original keyboard (so, English one). = I save > the original one when the module is loaded. > > =20 I mean imagine that you're in a face to a grub with klingon keyboard how would you find your way out? Also keyboard_layouts is pretty small. Perhaps we can just make *_keyboard depend on it and put US keyboard into it as default and shave some complexity this way > Thanks for the other comments, > > =20 --=20 Regards Vladimir '=CF=86-coder/phcoder' Serbinenko --------------enigFE9B012F3800DA784C535BE3 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iF4EAREKAAYFAktUd40ACgkQNak7dOguQgmeVQD/Xck0zf7MhjywcCsEkgBS+t1V y0oV+ir8AmMcJV50dK8A/20PGadOg26iW93puEcbaoutXfpeSYmMfNEDkMZxYLBn =zcVf -----END PGP SIGNATURE----- --------------enigFE9B012F3800DA784C535BE3--