From: Tilman Schmidt <tilman@imap.cc>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>,
David Miller <davem@davemloft.net>, Greg KH <gregkh@suse.de>,
Stephen Rothwell <sfr@canb.auug.org.au>,
LKML <linux-kernel@vger.kernel.org>,
netdev@vger.kernel.org, Karsten Keil <isdn@linux-pingi.de>,
isdn4linux@listserv.isdn4linux.de
Subject: Re: linux-next build failure (was: Re: [PATCH/REPOST] pci: push deprecated pci_find_device() function to last user)
Date: Mon, 18 Jan 2010 16:46:00 +0100 [thread overview]
Message-ID: <4B548238.9080008@imap.cc> (raw)
In-Reply-To: <10f740e81001180644yd44121cv6dd963349563a290@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1530 bytes --]
Am 18.01.2010 15:44 schrieb Geert Uytterhoeven:
> On Fri, Jan 15, 2010 at 19:08, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
>> On Thu, 14 Jan 2010 23:18:41 +0100 (CET)
>> Tilman Schmidt <tilman@imap.cc> wrote:
>>>
>>> Subject: [PATCH] pci: push deprecated pci_find_device() function to
>>> last user
>>>
>>> The ISDN4Linux HiSax driver family contains the last remaining users
>>> of the deprecated pci_find_device() function. This patch creates a
>>> private copy of that function in HiSax, and removes the now unused
>>> global function together with its controlling configuration option,
>>> CONFIG_PCI_LEGACY.
>>>
>>> Impact: code reorganization, no functional change
>>> Signed-off-by: Tilman Schmidt <tilman@imap.cc>
>>> ---
>>> Note: This patch is not, nor does it intend to be, checkpatch.pl
>>> clean. The issues checkpatch.pl reports on it were already present
>>> before, and are unrelated to the topic of this patch.
>>
>> Applied to my linux-next branch, thanks Tilman.
>
> Just guessing: something's wrong if CONFIG_PCI is not set?
>
> http://kisskb.ellerman.id.au/kisskb/buildresult/2042085/
Sorry, oversight of mine. I thought that hisax/avm_pci.c depended on
CONFIG_PCI, but it doesn't, as it also handles ISA PnP cards. I will
issue a corrected patch ASAP.
Thanks,
Tilman
--
Tilman Schmidt E-Mail: tilman@imap.cc
Bonn, Germany
Diese Nachricht besteht zu 100% aus wiederverwerteten Bits.
Ungeöffnet mindestens haltbar bis: (siehe Rückseite)
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]
prev parent reply other threads:[~2010-01-18 15:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-18 14:44 linux-next build failure (was: Re: [PATCH/REPOST] pci: push deprecated pci_find_device() function to last user) Geert Uytterhoeven
2010-01-18 14:44 ` Geert Uytterhoeven
2010-01-18 15:46 ` Tilman Schmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B548238.9080008@imap.cc \
--to=tilman@imap.cc \
--cc=davem@davemloft.net \
--cc=geert@linux-m68k.org \
--cc=gregkh@suse.de \
--cc=isdn4linux@listserv.isdn4linux.de \
--cc=isdn@linux-pingi.de \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.