From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH 01/64] libata: fix CFA handling in ide_timing_compute() Date: Mon, 18 Jan 2010 21:23:32 +0300 Message-ID: <4B54A724.6080701@ru.mvista.com> References: <20100118171349.14623.90030.sendpatchset@localhost> <20100118171357.14623.36435.sendpatchset@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from gateway-1237.mvista.com ([206.112.117.35]:38689 "HELO imap.sh.mvista.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with SMTP id S1751548Ab0ARSZU (ORCPT ); Mon, 18 Jan 2010 13:25:20 -0500 In-Reply-To: <20100118171357.14623.36435.sendpatchset@localhost> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Bartlomiej Zolnierkiewicz Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Hello. Bartlomiej Zolnierkiewicz wrote: > From: Bartlomiej Zolnierkiewicz > Subject: [PATCH] libata: fix CFA handling in ide_timing_compute() > > Use standard cycle timing for CFA PIO5 and PIO6 modes. > > Based on commit 74638c8 for IDE subsystem. > > Signed-off-by: Bartlomiej Zolnierkiewicz > --- > drivers/ata/libata-core.c | 17 +++++++++++------ > 1 file changed, 11 insertions(+), 6 deletions(-) > > Index: b/drivers/ata/libata-core.c > =================================================================== > --- a/drivers/ata/libata-core.c > +++ b/drivers/ata/libata-core.c > @@ -3211,6 +3211,7 @@ const struct ata_timing *ata_timing_find > int ata_timing_compute(struct ata_device *adev, unsigned short speed, > struct ata_timing *t, int T, int UT) > { > + const u16 *id = adev->id; > const struct ata_timing *s; > struct ata_timing p; > > @@ -3228,14 +3229,18 @@ int ata_timing_compute(struct ata_device > * PIO/MW_DMA cycle timing. > */ > > - if (adev->id[ATA_ID_FIELD_VALID] & 2) { /* EIDE drive */ > + if (id[ATA_ID_FIELD_VALID] & 2) { /* EIDE drive */ > memset(&p, 0, sizeof(p)); > + > if (speed >= XFER_PIO_0 && speed <= XFER_SW_DMA_0) { > BTW, shouldn't this actually be 'speed < XFER_SW_DMA_0'? MBR, Sergei