From: Gilles Chanteperdrix <gilles.chanteperdrix@xenomai.org>
To: Wolfgang Grandegger <wg@domain.hid>
Cc: xenomai-core <xenomai@xenomai.org>
Subject: Re: [Xenomai-core] [PATCH] rtcan_rtt: Various fixes and improvement
Date: Mon, 18 Jan 2010 22:07:20 +0100 [thread overview]
Message-ID: <4B54CD88.20201@domain.hid> (raw)
In-Reply-To: <4B54ACC8.9030006@domain.hid>
Wolfgang Grandegger wrote:
> Gilles Chanteperdrix wrote:
>> Wolfgang Grandegger wrote:
>>> This patch fixes type long overflows, invalid command line argument
>>> types and gives the receiver and transmitter thread dedicated names.
>>>
>>> Signed-off-by: Wolfgang Grandegger <wg@domain.hid>
>>>
>>> diff --git a/examples/rtdm/profiles/can/rtcan_rtt.c
>>> b/examples/rtdm/profiles/can/rtcan_rtt.c
>>> index 93c84a6..2280562 100644
>>> --- a/examples/rtdm/profiles/can/rtcan_rtt.c
>>> +++ b/examples/rtdm/profiles/can/rtcan_rtt.c
>>> @@ -94,6 +94,7 @@ void *transmitter(void *arg)
>>> frame.can_id = can_id;
>>> frame.can_dlc = sizeof(*rtt_time);
>>>
>>> + pthread_set_name_np(pthread_self(), "rtcan_rtt_transmitter");
>> Maybe we should put this between #ifdef __XENO__, so that the code
>> compiles under plain posix too?
>
> Good idea but it requires a few more changes. See below:
Fine. Merged, thanks.
--
Gilles.
prev parent reply other threads:[~2010-01-18 21:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-18 14:06 [Xenomai-core] [PATCH] rtcan_rtt: Various fixes and improvement Wolfgang Grandegger
2010-01-18 14:10 ` Gilles Chanteperdrix
2010-01-18 18:47 ` Wolfgang Grandegger
2010-01-18 21:07 ` Gilles Chanteperdrix [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B54CD88.20201@domain.hid \
--to=gilles.chanteperdrix@xenomai.org \
--cc=wg@domain.hid \
--cc=xenomai@xenomai.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.