All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Warren <biggerbadderben@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Fix breakage in SMC EEPROM standalone applications
Date: Mon, 18 Jan 2010 15:15:32 -0800	[thread overview]
Message-ID: <4B54EB94.3030405@gmail.com> (raw)
In-Reply-To: <4B54D424.304@windriver.com>

Hi Tom,

Tom wrote:
> Ben Warren wrote:
>> Commit 6a45e384955262882375a2785426dc65aeb636c4 (Make getenv_IPaddr() 
>> global)
>> inadvertently added ' #include "net.h" ' to the standalone programs, 
>> creating
>> duplicate definitions of 'struct eth_device'.  This patch removes the 
>> local
>> definitions and removes other code that breaks due to the change in 
>> definition.
>
> This patch may need refining.
> I see warnings in a number of arm targets
>
> Old :
> err/versatile.ERR
>
> smc91111_eeprom.c:33: error: redefinition of 'struct eth_device'
> make[1]: *** [.../build/examples/standalone/smc91111_eeprom.o] Error 1
>
> New
>
> err/versatile.ERR
> .../build/examples/standalone/smc91111_eeprom.o: In function 
> `smc91111_eeprom':
> .../u-boot/src/u-boot-arm/examples/standalone/smc91111_eeprom.c:58: 
> undefined reference to `memset'
> make[1]: *** [.../build/examples/standalone/smc91111_eeprom] Error 1
>
> Tom
>
This builds cleanly for me.  I am, however, using an old toolchain (gcc 
4.0.0 from ELDK 4.1).  Do struct member assignments use memset()?  Line 
58 is the closing brace and semicolon in the following:

        struct eth_device dev = {
                .iobase = CONFIG_SMC91111_BASE
        };

regards,
Ben

  parent reply	other threads:[~2010-01-18 23:15 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-18 19:35 [U-Boot] [PATCH] Fix breakage in SMC EEPROM standalone applications Ben Warren
2010-01-18 19:44 ` Dirk Behme
2010-01-18 22:02 ` Mike Frysinger
2010-01-18 23:06 ` Wolfgang Denk
     [not found] ` <4B54D424.304@windriver.com>
2010-01-18 23:15   ` Ben Warren [this message]
2010-01-18 23:42     ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B54EB94.3030405@gmail.com \
    --to=biggerbadderben@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.