From: Avi Kivity <avi@redhat.com>
To: Sheng Yang <sheng@linux.intel.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>, kvm@vger.kernel.org
Subject: Re: [PATCH] KVM: Add missing emulation failure report in kvm_mmu_page_fault()
Date: Tue, 19 Jan 2010 09:54:44 +0200 [thread overview]
Message-ID: <4B556544.5070005@redhat.com> (raw)
In-Reply-To: <201001191106.09684.sheng@linux.intel.com>
On 01/19/2010 05:06 AM, Sheng Yang wrote:
>
>> There are two problems with the kernel failure report. First, it
>> doesn't report enough data - registers, surrounding instructions, etc.
>> that are needed to explain what is going on. Second, it can flood
>> dmesg, which is a pretty bad thing to do.
>>
>
> When you talking about "built-in disassembler", do you talking about
> "memsave/objdump" or some other more convenient way for this?
>
> And maybe we can let QEmu do some dump of the assembler code?
> (kvm_show_code())
>
In the qemu monitor, type 'x/20i $eip' to get a disassembly of code
around the current instruction pointer.
>> I have a patch somewhere that adds instruction emulation bytes (both
>> successful and failed) to ftrace. That may be useful, perhaps.
>>
> It would surely help. :)
>
I'll try to resurrect it.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2010-01-19 7:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-15 8:44 [PATCH] KVM: Add missing emulation failure report in kvm_mmu_page_fault() Sheng Yang
2010-01-17 12:34 ` Avi Kivity
2010-01-18 9:32 ` Sheng Yang
2010-01-18 11:32 ` Avi Kivity
2010-01-19 3:06 ` Sheng Yang
2010-01-19 7:54 ` Avi Kivity [this message]
2010-01-19 7:57 ` Gleb Natapov
2010-01-19 8:05 ` Sheng Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B556544.5070005@redhat.com \
--to=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=sheng@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.