From: Gustaf Hendeby <hendeby@isy.liu.se>
To: Johannes Sixt <j.sixt@viscovery.net>
Cc: Jacob Helwig <jacob.helwig@gmail.com>,
git@vger.kernel.org, Jens.Lehmann@web.de
Subject: Re: Unmodified submodules shows up as dirty with 1.6.6.443.gd7346
Date: Tue, 19 Jan 2010 09:23:38 +0100 [thread overview]
Message-ID: <4B556C0A.9020204@isy.liu.se> (raw)
In-Reply-To: <4B555BA1.90605@viscovery.net>
Johannes Sixt wrote:
> Jacob Helwig schrieb:
>> If there is no output from git status in the submodule, then git
>> status in the superproject shows the submodule as being clean.
>> However, if there is _any_ output from git status (untracked files,
>> modified files, deleted files, new files), then the superproject shows
>> the submodule as being dirty.
>
> But isn't it a bug that a submodule is considered dirty just because an
> untracked file appears?
I prefer the old behavior, and find the new one a bit unintuitive and I
suspect it will hit more people than just me once the change ends up on
master. Unfortunately, the response yesterday pointed in the direction
of this being a wanted feature. I think the change of behavior should
at least be mentioned in the release note.
/Gustaf
next prev parent reply other threads:[~2010-01-19 8:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-18 15:30 Unmodified submodules shows up as dirty with 1.6.6.443.gd7346 Gustaf Hendeby
2010-01-18 16:02 ` Jacob Helwig
2010-01-18 16:54 ` Gustaf Hendeby
2010-01-18 17:14 ` Jacob Helwig
2010-01-18 17:27 ` Gustaf Hendeby
2010-01-18 17:22 ` Junio C Hamano
2010-01-18 20:50 ` Jens Lehmann
2010-01-19 7:13 ` Johannes Sixt
2010-01-19 8:23 ` Gustaf Hendeby [this message]
2010-01-19 14:31 ` Jacob Helwig
2010-01-19 17:29 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B556C0A.9020204@isy.liu.se \
--to=hendeby@isy.liu.se \
--cc=Jens.Lehmann@web.de \
--cc=git@vger.kernel.org \
--cc=j.sixt@viscovery.net \
--cc=jacob.helwig@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.