From: Romit Dasgupta <romit@ti.com>
To: "eduardo.valentin@nokia.com" <eduardo.valentin@nokia.com>
Cc: ext Nishanth Menon <menon.nishanth@gmail.com>,
ext Kevin Hilman <khilman@deeprootsystems.com>,
Linux-OMAP <linux-omap@vger.kernel.org>
Subject: Re: [PATCH 1/1] OMAP3: PM: Fix compilation issue of omap3_pm_init_opp_table
Date: Tue, 19 Jan 2010 19:39:23 +0530 [thread overview]
Message-ID: <4B55BD13.70704@ti.com> (raw)
In-Reply-To: <20100119134927.GE12231@esdhcp037198.research.nokia.com>
>>>
>> Err... NAK.. I think you missed
>> http://marc.info/?t=126356119700001&r=1&w=2 ?
>> there seems to be an issue else where, I have not dug at it yet..
>
>
> Yeah. OK, I couldn't see the logs as the dumps has been removed already from that thread.
> But if I got the problem correctly, the problem is when CONFIG_PM is not set but cpu freq is.
> And if there is any call to new omap opp layer helper functions, then it will BUG the system.
> Causing hangs.
>
> I guess one way to solve this is to bind compilation of omap opp layer to CONFIG_PM and CONFIG_CPU_FREQ.
> If either is disabled, then omap opp layer must be nops.
>
> What do you think?
>
> I am sending a patch to do the above.
No. That is incorrect. CONFIG_CPU_FREQ, CONFIG_CPU_IDLE and CONFIG_PM are
independent. None of the features should be dependent on the other two!
-Romit
next prev parent reply other threads:[~2010-01-19 14:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-19 11:57 [PATCH 1/1] OMAP3: PM: Fix compilation issue of omap3_pm_init_opp_table Eduardo Valentin
2010-01-19 12:01 ` Nishanth Menon
2010-01-19 13:49 ` Eduardo Valentin
2010-01-19 14:09 ` Romit Dasgupta [this message]
2010-01-19 14:32 ` Nishanth Menon
2010-01-19 14:41 ` Romit Dasgupta
2010-01-19 14:42 ` Nishanth Menon
2010-01-19 14:43 ` Romit Dasgupta
2010-01-19 14:45 ` Nishanth Menon
2010-01-19 14:50 ` Romit Dasgupta
2010-01-19 15:15 ` Nishanth Menon
2010-01-19 17:02 ` Dasgupta, Romit
2010-01-19 15:35 ` Cousson, Benoit
2010-01-19 17:00 ` Dasgupta, Romit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B55BD13.70704@ti.com \
--to=romit@ti.com \
--cc=eduardo.valentin@nokia.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-omap@vger.kernel.org \
--cc=menon.nishanth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.