From: Felix Fietkau <nbd@openwrt.org>
To: "Luis R. Rodriguez" <mcgrof@bombadil.infradead.org>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
"Luis R. Rodriguez" <lrodriguez@atheros.com>
Subject: Re: [PATCH 2/2] compat: fix compile errors with CONFIG_FW_LOADER unset
Date: Tue, 19 Jan 2010 20:40:38 +0100 [thread overview]
Message-ID: <4B560AB6.7090405@openwrt.org> (raw)
In-Reply-To: <20100119193545.GA8069@bombadil.infradead.org>
On 2010-01-19 8:35 PM, Luis R. Rodriguez wrote:
> what about something like this? This is not tested on a system without
> FW_LOADER yet, not sure if it works:
>
> diff --git a/Makefile b/Makefile
> index 4843869..ad8a602 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -19,8 +19,13 @@ $(foreach ver,$(COMPAT_VERSIONS),$(eval export CONFIG_COMPAT_KERNEL_$(ver)=y))
> endif
>
> ifeq ($(CONFIG_COMPAT_KERNEL_33),y)
> +ifeq ($(CONFIG_FW_LOADER),y)
> export CONFIG_COMPAT_FIRMWARE_CLASS=m
> endif
> +ifeq ($(CONFIG_FW_LOADER_MODULE),y)
> + export CONFIG_COMPAT_FIRMWARE_CLASS=m
> +endif
> +endif
>
> obj-y += compat/
>
>
> Oh well this is just for compat.git but we'd do something similar on config.mk
> Testing to build compat.git should suffice though I think.
Sounds good.
- Felix
next prev parent reply other threads:[~2010-01-19 19:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-18 14:29 [PATCH 1/2] compat: fix firmware class compile on linux 2.6.32 Felix Fietkau
2010-01-18 14:30 ` [PATCH 2/2] compat: fix compile errors with CONFIG_FW_LOADER unset Felix Fietkau
2010-01-19 19:35 ` Luis R. Rodriguez
2010-01-19 19:40 ` Felix Fietkau [this message]
2010-01-19 23:53 ` Luis R. Rodriguez
2010-01-19 19:22 ` [PATCH 1/2] compat: fix firmware class compile on linux 2.6.32 Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B560AB6.7090405@openwrt.org \
--to=nbd@openwrt.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lrodriguez@atheros.com \
--cc=mcgrof@bombadil.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.