From: "H. Peter Anvin" <hpa@zytor.com>
To: Christoph Lameter <cl@linux-foundation.org>
Cc: Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org, Andi Kleen <andi@firstfloor.org>
Subject: Re: [x86] Unify semaphore_32.S and rwlock_64.S
Date: Tue, 19 Jan 2010 14:30:38 -0800 [thread overview]
Message-ID: <4B56328E.9080108@zytor.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1001191616280.28622@router.home>
On 01/19/2010 02:21 PM, Christoph Lameter wrote:
>
> From: Christoph Lameter <cl@linux-foundation.org>
> Subject: [x86] Unify semaphore_32.S and rwlock_64.S
>
> Both implement semaphore handling and the code for __read_lock_failed()
> and __write_lock_failed() look eearily similar aside from the use of
> different registers.
>
> Create a new arch/x86/lib/semaphore.S out of the two files.
>
Hi Christoph,
Could you do this in the standard sequencing for unification patches:
first patch the two pieces of code so they are identical, and then
mechanically unifying them? Otherwise it's almost impossible to see
what has changed.
> This is also a good preparatory patch for getting the rwsem XADD stuff
> to work on x86_64.
Have you tried the tip:x86/rwsem branch (Linus' work with a few
additions of mine) and had it not work for you?
> x86_64 gains the FRAME/ENDFRAME handling that i386 has (not sure what the
> point is of having that there).
Presumably it's so you can have frame pointers everywhere.
-hpa
next prev parent reply other threads:[~2010-01-19 22:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-19 22:21 [x86] Unify semaphore_32.S and rwlock_64.S Christoph Lameter
2010-01-19 22:30 ` H. Peter Anvin [this message]
2010-01-20 19:49 ` Christoph Lameter
2010-01-20 20:14 ` H. Peter Anvin
2010-01-20 20:51 ` Christoph Lameter
2010-01-20 23:57 ` Linus Torvalds
2010-01-21 0:02 ` H. Peter Anvin
2010-01-21 6:28 ` H. Peter Anvin
2010-01-21 0:46 ` Linus Torvalds
2010-01-21 0:55 ` H. Peter Anvin
2010-01-20 23:46 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B56328E.9080108@zytor.com \
--to=hpa@zytor.com \
--cc=andi@firstfloor.org \
--cc=cl@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.