From: Anthony Liguori <anthony@codemonkey.ws>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/4] clean up env->current_tb
Date: Tue, 19 Jan 2010 16:40:14 -0600 [thread overview]
Message-ID: <4B5634CE.4080304@codemonkey.ws> (raw)
In-Reply-To: <1263544930-18620-2-git-send-email-pbonzini@redhat.com>
On 01/15/2010 02:42 AM, Paolo Bonzini wrote:
> There are three paths from the innermost while loop of cpu_exec
> to the top of the outermost for loop. Two do not reset
> env->current_tb. Fix this.
>
> Signed-off-by: Paolo Bonzini<pbonzini@redhat.com>
>
Applied. Thanks.
Regards,
Anthony Liguori
> ---
> cpu-exec.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/cpu-exec.c b/cpu-exec.c
> index 6f6ed14..9128df9 100644
> --- a/cpu-exec.c
> +++ b/cpu-exec.c
> @@ -56,6 +56,7 @@ int qemu_cpu_has_work(CPUState *env)
>
> void cpu_loop_exit(void)
> {
> + env->current_tb = NULL;
> longjmp(env->jmp_env, 1);
> }
>
> @@ -107,6 +108,7 @@ static void cpu_exec_nocache(int max_cycles, TranslationBlock *orig_tb)
> env->current_tb = tb;
> /* execute the generated code */
> next_tb = tcg_qemu_tb_exec(tb->tc_ptr);
> + env->current_tb = NULL;
>
> if ((next_tb& 3) == 2) {
> /* Restore PC. This may happen if async event occurs before
>
next prev parent reply other threads:[~2010-01-19 22:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-15 8:42 [Qemu-devel] [PATCH 0/4] Clean up cpu_exec part 2/n Paolo Bonzini
2010-01-15 8:42 ` [Qemu-devel] [PATCH 1/4] clean up env->current_tb Paolo Bonzini
2010-01-19 22:40 ` Anthony Liguori [this message]
2010-01-15 8:42 ` [Qemu-devel] [PATCH 2/4] add assertions about env->current_tb Paolo Bonzini
2010-01-15 8:42 ` [Qemu-devel] [PATCH 3/4] change while to if Paolo Bonzini
2010-01-15 8:42 ` [Qemu-devel] [PATCH 4/4] remove assertions Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B5634CE.4080304@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.