From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: ben-linux@fluff.org, linux-mmc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] s3cmci: Initialize default platform data no_wprotect and no_detect with 1
Date: Wed, 20 Jan 2010 13:44:26 +0300 [thread overview]
Message-ID: <4B56DE8A.70209@ru.mvista.com> (raw)
In-Reply-To: <1263975361-29376-1-git-send-email-lars@metafoo.de>
Hello.
Lars-Peter Clausen wrote:
> If no platform_data was givin to the device it's going to use it's default
> platform data struct which has all fields initialized to zero.
> As a result the driver is going to try to request gpio0 both as write protect
> and card detect pin. Which of course will fail and makes the driver unusable
>
> Previously to the introduction of no_wprotect and no_detect the behavior was
> to assume that if no platform data was given there is no write protect or card
> detect pin.
> This patch restores that behavior.
>
The very idea of the default platform data seems dubious...
WBR, Sergei
next prev parent reply other threads:[~2010-01-20 10:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-20 8:16 [PATCH 1/2] s3cmci: Initialize default platform data no_wprotect and no_detect with 1 Lars-Peter Clausen
2010-01-20 8:16 ` Lars-Peter Clausen
2010-01-20 8:16 ` [PATCH 2/2] s3cmci: s3cmci_card_present: Use no_detect to decide whether there is a card detect pin Lars-Peter Clausen
2010-01-20 8:16 ` Lars-Peter Clausen
2010-01-20 10:44 ` Sergei Shtylyov [this message]
2010-01-20 10:59 ` [PATCH 1/2] s3cmci: Initialize default platform data no_wprotect and no_detect with 1 Lars-Peter Clausen
2010-01-20 10:59 ` Lars-Peter Clausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B56DE8A.70209@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=ben-linux@fluff.org \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.