From: Jeff Garzik <jeff@garzik.org>
To: Tejun Heo <tj@kernel.org>
Cc: "linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
Johannes Stezenbach <js@sig21.net>
Subject: Re: [PATCH #upstream-fixes] libata: retry FS IOs even if it has failed with AC_ERR_INVALID
Date: Wed, 20 Jan 2010 14:25:37 -0500 [thread overview]
Message-ID: <4B5758B1.3060704@garzik.org> (raw)
In-Reply-To: <4B4EC531.2010001@kernel.org>
On 01/14/2010 02:18 AM, Tejun Heo wrote:
> libata currently doesn't retry if a command fails with AC_ERR_INVALID
> assuming that retrying won't get it any further even if retried.
> However, a failure may be classified as invalid through hardware
> glitch (incorrect reading of the error register or firmware bug) and
> there isn't whole lot to gain by not retrying as actually invalid
> commands will be failed immediately. Also, commands serving FS IOs
> are extremely unlikely to be invalid. Retry FS IOs even if it's
> marked invalid.
>
> Transient and incorrect invalid failure was seen while debugging
> firmware related issue on Samsung n130 on bko#14314.
>
> http://bugzilla.kernel.org/show_bug.cgi?id=14314
>
> Signed-off-by: Tejun Heo<tj@kernel.org>
> Reported-by: Johannes Stezenbach<js@sig21.net>
applied
prev parent reply other threads:[~2010-01-20 19:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-14 7:18 [PATCH #upstream-fixes] libata: retry FS IOs even if it has failed with AC_ERR_INVALID Tejun Heo
2010-01-20 19:25 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B5758B1.3060704@garzik.org \
--to=jeff@garzik.org \
--cc=js@sig21.net \
--cc=linux-ide@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.