From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1NXgc0-0007Rg-82 for mharc-grub-devel@gnu.org; Wed, 20 Jan 2010 14:53:08 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NXgbx-0007Oa-Hv for grub-devel@gnu.org; Wed, 20 Jan 2010 14:53:05 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NXgbw-0007Nb-Mw for grub-devel@gnu.org; Wed, 20 Jan 2010 14:53:05 -0500 Received: from [199.232.76.173] (port=35298 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NXgbw-0007NP-GL for grub-devel@gnu.org; Wed, 20 Jan 2010 14:53:04 -0500 Received: from ey-out-1920.google.com ([74.125.78.144]:49155) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NXgbw-0007L7-3L for grub-devel@gnu.org; Wed, 20 Jan 2010 14:53:04 -0500 Received: by ey-out-1920.google.com with SMTP id 26so1218441eyw.34 for ; Wed, 20 Jan 2010 11:53:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=O8BspZx18+8rJIkGxfKQzcagkhwJ+VqW9Z2WEnhJ7GE=; b=hwu0NI/r6EVplWeebieLNHIWttOMnuXruYikNUqJShD7nWObJ0+dEiGeCPSs8H2qXU 91XvZEYRPpr0lKv0WtajE7UOL4zJXq6w2l8MMY42DPC487pO9CyOJrvP49f8EkWvYBXo +iDsu8JEL/Rf9y2llTcwjZyL1NaE66wVnUv6U= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; b=qnOz9np2Qe/3+zrQgIbCRhbdIpc1qRk4/WaA9sNnJlUAfFDnqzHOYogOL27pbtKLzF NckrD/VegCcatAs5Qa94pM5H/UBUimVsMSfAuYViUwNV07O911dmlSA4S22yPe7izpPC 28ZbmGYBkCccV4gzbmCMxbxEBhOuME7AfR1JI= Received: by 10.213.2.81 with SMTP id 17mr1412451ebi.83.1264017182954; Wed, 20 Jan 2010 11:53:02 -0800 (PST) Received: from ?192.168.1.50? (c2433-1-88-160-112-182.fbx.proxad.net [88.160.112.182]) by mx.google.com with ESMTPS id 10sm319979eyd.21.2010.01.20.11.53.02 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 20 Jan 2010 11:53:02 -0800 (PST) Message-ID: <4B575F1D.3090601@gmail.com> Date: Wed, 20 Jan 2010 20:53:01 +0100 From: =?UTF-8?B?R3LDqWdvaXJlIFN1dHJl?= User-Agent: Mozilla-Thunderbird 2.0.0.22 (X11/20090707) MIME-Version: 1.0 To: The development of GNU GRUB References: <4B4CC4EF.5000104@gmail.com> <2e59e6971001121109t5314e819t30ee70bb509254e2@mail.gmail.com> <4B4CCE14.7060706@gmail.com> <2e59e6971001121259w18ebb724i52ed5ad6a791d00a@mail.gmail.com> <4B4D1B9E.3070505@gmail.com> <20100119233811.GP8599@thorin> In-Reply-To: <20100119233811.GP8599@thorin> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: Build error: "ENABLE_NLS" is not defined X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Jan 2010 19:53:05 -0000 Robert Millan wrote: > This affects gnulib/error.c and gnulib/gettext.h which would be much better > not to change, as they're being imported semi-automatically. I understand. But could this be actually a bug in gnulib? The problem only occurs when gettext is not found and when compiling with -Wundef -Werror, so maybe it went unnoticed? > Perhaps you could solve this at its source? (i.e. by defining ENABLE_NLS to > 0 when gettext is unavailable). Indeed, the problem is gone when the following line is added before the call to AM_GNU_GETTEXT in configure.ac: AC_DEFINE([ENABLE_NLS], [0]) It does not really solve the problem at its source, though. ENABLE_NLS is defined in AM_GNU_GETTEXT and the documentation of this macro [1] does not require ENABLE_NLS to be defined when gettext is not available. Best regards, Grégoire [1] http://www.gnu.org/software/hello/manual/gettext/AM_005fGNU_005fGETTEXT.html