From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [Patch 4/7] tabled: retry conflicting locks Date: Wed, 20 Jan 2010 14:53:17 -0500 Message-ID: <4B575F2D.3070403@garzik.org> References: <20100114211312.2df3d349@redhat.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:message-id:date:from :user-agent:mime-version:to:cc:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=hY2GQ3GE+AtS6qsi7C95sWpHysxOu8+CAAzlWKo2aPI=; b=FyD8SP1yi+59Zxk8ZzdN14DEFofQq87SfKnej/r4BP1rCpCuMSzV05V4V1yLsDBJFM UcHlWeAyYOynFi1qjcdxUukJxQsluF4Pf8QX3wkBteHFurmzA7VhJTmlHGwre+E0fTIW fJOy1VeOh6f0hGjnu8w1R45tfbz+7moBFTEqA= In-Reply-To: <20100114211312.2df3d349@redhat.com> Sender: hail-devel-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii"; format="flowed" To: Pete Zaitcev Cc: Project Hail List On 01/14/2010 11:13 PM, Pete Zaitcev wrote: > This problem was with us for a while, and even with this fix our start-up > is not reliable. But at least we will not be 100% guaranteed to hang as > before when restarting too quickly. So although the whole area needs some > serious reworking, this specific case was just too annoying to let it > continue. > > Signed-Off-By: Pete Zaitcev > > --- > server/cldu.c | 38 ++++++++++++++++++++++++++++++++++---- > 1 file changed, 34 insertions(+), 4 deletions(-) This is not correct. CLD has blocking locks. You issue the LOCK op, and will be notified when you have acquired the lock, possibly hours or days later. There is no need to retry anything... Jeff