All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pete Harlan <pgit@pcharlan.com>
To: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Cc: Junio C Hamano <gitster@pobox.com>,
	Johannes Sixt <j.sixt@viscovery.net>,
	sschuberth@gmail.com, GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [PATCH 1/4] engine.pl: Fix a recent breakage of the buildsystem generator
Date: Wed, 20 Jan 2010 12:57:28 -0800	[thread overview]
Message-ID: <4B576E38.5080604@pcharlan.com> (raw)
In-Reply-To: <4B575838.2010504@ramsay1.demon.co.uk>

On 01/20/2010 11:23 AM, Ramsay Jones wrote:
> diff --git a/contrib/buildsystems/engine.pl b/contrib/buildsystems/engine.pl
> index d506717..245af73 100644
> --- a/contrib/buildsystems/engine.pl
> +++ b/contrib/buildsystems/engine.pl
> @@ -135,6 +135,11 @@ sub parseMakeOutput
>              }
>          } while($ate_next);
>  
> +        if ($text =~ /^test / && $text =~ /|| rm -f /) {

That test on the right needs to escape its pipes or it will always match.

--Pete

> +            # commands removing executables, if they exist
> +            next;
> +        }
> +
>          if($text =~ / -c /) {
>              # compilation
>              handleCompileLine($text, $line);

  reply	other threads:[~2010-01-20 20:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-20 19:23 [PATCH 1/4] engine.pl: Fix a recent breakage of the buildsystem generator Ramsay Jones
2010-01-20 20:57 ` Pete Harlan [this message]
2010-01-22 18:58   ` Ramsay Jones
2010-01-20 22:54 ` Sebastian Schuberth
2010-01-22 19:40   ` Ramsay Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B576E38.5080604@pcharlan.com \
    --to=pgit@pcharlan.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=j.sixt@viscovery.net \
    --cc=ramsay@ramsay1.demon.co.uk \
    --cc=sschuberth@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.