From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [Patch 3/7] tabled: add the status display Date: Wed, 20 Jan 2010 16:49:57 -0500 Message-ID: <4B577A85.8080301@garzik.org> References: <20100114211216.53d51c13@redhat.com> <4B575EDF.3020203@garzik.org> <20100120131950.2ce72e71@redhat.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:message-id:date:from :user-agent:mime-version:to:cc:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=YkayJXyspJRq6L83qAibqUWhQCUH502uSgx9t4Fr9Xo=; b=N4nFP1r3sl2IdDxsKAOfqJIq85HmWSZibOjV4q0g5Ay+B1SMjpPeDIlIjXeP9kTUoO yYncxnU0ZwcczCN1hXTQYkUOC2ff0/f4pTpsmWSxQ1OQ/nxcp1ZtlteWtqoQHN5x+Wkb UbPywulad4ayyB35TWe3YV87+IyYgiUGMsRf8= In-Reply-To: <20100120131950.2ce72e71@redhat.com> Sender: hail-devel-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii"; format="flowed" To: Pete Zaitcev Cc: Project Hail List On 01/20/2010 03:19 PM, Pete Zaitcev wrote: > On Wed, 20 Jan 2010 14:51:59 -0500 > Jeff Garzik wrote: > >> On 01/14/2010 11:12 PM, Pete Zaitcev wrote: >>> I find it too tiresome to monitor the status with kill -USR1. >>> This is more fun. The patch seems not too ugly regarding the factoring >>> of the cli_xxx methods. >>> >>> Signed-Off-By: Pete Zaitcev >>> >>> --- >>> doc/etc.tabled.conf | 3 >>> server/Makefile.am | 4 >>> server/config.c | 19 +++ >>> server/replica.c | 64 +++++++++++- >>> server/server.c | 104 +++++++++++++------- >>> server/status.c | 218 ++++++++++++++++++++++++++++++++++++++++++ >>> server/tabled.h | 12 +- >>> 7 files changed, 379 insertions(+), 45 deletions(-) >> >> applied... but we need some way to either turn this off, or limit to a >> list of incoming IP addresses. This is an admin interface, which should >> not be automatically available to all end-user applications. > > I thought it was obvious that StatusPort defaults to off (zero). > > if (tabled_srv.status_port) > net_open_known(tabled_srv.status_port, true); I missed that detail. That works. Though eventually I hope someone will create a patch for filtering incoming connections via IP address. Not an issue that needs attention pre-1.0 unless a volunteer appears, though. Jeff